public inbox for dri-devel@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jake S <j@metarealtyinc.ca>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	jani.nikula@intel.com, rodrigo.vivi@intel.com
Subject: Re: [PATCH 0/2] drm: Enable eDP VRR for panels with DisplayID Adaptive Sync
Date: Wed, 15 Apr 2026 17:05:37 +0300	[thread overview]
Message-ID: <ad-bMVzfARer7fMo@intel.com> (raw)
In-Reply-To: <20260415130626.10523-1-j@metarealtyinc.ca>

On Wed, Apr 15, 2026 at 09:06:24AM -0400, Jake S wrote:
> Many 2025-2026 laptops (Dell XPS, Framework, etc.) ship with OLED eDP
> panels that support VRR 20-120Hz. These panels advertise their VRR
> capability through a DisplayID v2.0 Adaptive Sync Data Block (tag 0x2B)
> in their EDID. VRR works fine on Windows.
> 
> On Linux, VRR is broken due to two issues:
> 
> 1. The DRM EDID parser (drm_edid.c) only reads monitor range from the
>    base EDID Display Range Limits descriptor (tag 0xFD). It does not
>    parse the DisplayID Adaptive Sync block. This leaves monitor_range
>    zeroed. AMD's driver has a private workaround; the generic DRM
>    layer does not.
> 
> 2. The Intel display driver (intel_vrr.c) gates eDP VRR on a VBT
>    (Video BIOS Table) firmware flag. Most OEMs don't set this flag
>    because the Windows driver doesn't need it. This blocks VRR even
>    when the EDID clearly declares support.
> 
> This series fixes both issues:
>  - Patch 1 adds generic DisplayID Adaptive Sync parsing to drm_edid.c,
>    benefiting all DRM drivers.
>  - Patch 2 relaxes the Intel eDP VRR gate to also accept EDID-based
>    capability when the VBT flag is absent.
> 
> Tested on Dell XPS 2026 (Intel Panther Lake, xe driver, LG Display
> OLED 3200x2000). VRR 20-120Hz confirmed via kernel vblank event
> tracing -- display dynamically varies between 32Hz (idle) and 120Hz
> (active rendering).
> 
> Related work: Adriano Vero posted a similar DisplayID range parsing
> patch to LKML (2026-03-28) which has not yet been merged.

Why did you post a different version?

> 
> GitHub: https://github.com/jibsta210/edp-vrr-linux
> 
> Jake S (2):
>   drm/edid: populate monitor_range from DisplayID Adaptive Sync block
>   drm/i915/display: allow eDP VRR when EDID has adaptive sync range
> 
>  gpu/drm/drm_edid.c               | 53 ++++++++++++++++++++++++++++++++
>  gpu/drm/i915/display/intel_vrr.c |  7 ++++-
>  2 files changed, 59 insertions(+), 1 deletion(-)
> 
> -- 
> 2.53.0

-- 
Ville Syrjälä
Intel

      parent reply	other threads:[~2026-04-15 14:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260415130626.10523-1-j@metarealtyinc.ca>
     [not found] ` <20260415130626.10523-3-j@metarealtyinc.ca>
2026-04-15 14:01   ` [PATCH 2/2] drm/i915/display: allow eDP VRR when EDID has adaptive sync range Ville Syrjälä
     [not found]   ` <69dfe22f.050a0220.301b30.5755@mx.google.com>
2026-04-15 19:16     ` Ville Syrjälä
2026-04-15 14:05 ` Ville Syrjälä [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad-bMVzfARer7fMo@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=j@metarealtyinc.ca \
    --cc=jani.nikula@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox