dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Wojciech Dubowik <Wojciech.Dubowik@mt.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>, Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Marek Vasut <marex@denx.de>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: sn65dsi83: Add reverse lanes property
Date: Thu, 9 Jul 2026 14:57:19 +0200	[thread overview]
Message-ID: <ak-ar-4hTQYgCrZT@mt.com> (raw)
In-Reply-To: <20260709091705.GA547298@killaraus.ideasonboard.com>

On Thu, Jul 09, 2026 at 12:17:05PM +0300, Laurent Pinchart wrote:
> On Thu, Jul 09, 2026 at 10:33:36AM +0200, Alexander Stein wrote:
> > Am Dienstag, 7. Juli 2026, 09:02:42 CEST schrieb Wojciech Dubowik:
> > > From: Wojciech Dubowik <Wojciech.Dubowik@mt.com>
> > > 
> > > Add reverse lvds lanes property for endpoints. It reverses
> > > the data-lanes order i.e. <4 3 2 1> instead of default
> > > <1 2 3 4>.
> > 
> > Wouldn't it be more reasonable to parse the data-lanes property and check
> > for the order instead of introducing a new property?
> 
> I think so. That's the intended usage of data-lanes, the property is
> meant to convey the order of lanes in addition to the count. Otherwise
> we would have used a data-lanes-count property instead.

I will send v2 with data-lanes parsing instead of adding new dt property.
Regards,
Wojtek

> 
> > > Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@mt.com>
> > > ---
> > >  .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml      | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > > index e69b6343a8eb..44483e808af9 100644
> > > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > > @@ -115,6 +115,10 @@ $defs:
> > >              enum: [100, 200]
> > >              default: 200
> > >  
> > > +          ti,lvds-reverse-lanes:
> > > +            description: Reverse the order of LVDS lanes.
> > > +            type: boolean
> > > +
> > >            ti,lvds-vod-swing-clock-microvolt:
> > >              description: LVDS diferential output voltage <min max> for clock
> > >                lanes in microvolts.
> 
> -- 
> Regards,
> 
> Laurent Pinchart

  reply	other threads:[~2026-07-10  7:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07  7:02 [PATCH 0/2] drm/bridge: ti-sn65dsi83: Add reverse lvds lanes DT property Wojciech Dubowik
2026-07-07  7:02 ` [PATCH 1/2] dt-bindings: display: sn65dsi83: Add reverse lanes property Wojciech Dubowik
2026-07-07  7:45   ` sashiko-bot
2026-07-07 16:21     ` Conor Dooley
2026-07-08 10:56       ` Wojciech Dubowik
2026-07-09  8:33   ` Alexander Stein
2026-07-09  9:17     ` Laurent Pinchart
2026-07-09 12:57       ` Wojciech Dubowik [this message]
2026-07-07  7:02 ` [PATCH 2/2] drm/bridge: ti-sn65dsi83: Add reverse lvds " Wojciech Dubowik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ak-ar-4hTQYgCrZT@mt.com \
    --to=wojciech.dubowik@mt.com \
    --cc=airlied@gmail.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=andrzej.hajda@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marex@denx.de \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox