Re: [PATCH 1/2] dt-bindings: display: sn65dsi83: Add reverse lanes property

[Wojciech Dubowik <wojciech.dubowik@mt.com>]

On Tue, Jul 07, 2026 at 05:21:19PM +0100, Conor Dooley wrote:
Hi Conor,

> On Tue, Jul 07, 2026 at 07:45:00AM +0000, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [Low] The patch introduces a custom vendor-specific boolean property `ti,lvds-reverse-lanes` to indicate LVDS lane reversal. This is a device tree anti-pattern because the referenced standard `video-interfaces.yaml` already provides the `data-lanes` property for this exact purpose (e.g., `data-lanes = <4 3 2 1>;`).
> > --
> > 
> > --- Patch [1]: [PATCH 1/2] dt-bindings: display: sn65dsi83: Add reverse lanes property ---
> > commit c30eea01a74188461b7e527f71d282d68b885ec2
> > Author: Wojciech Dubowik <Wojciech.Dubowik@mt.com>
> > 
> > dt-bindings: display: sn65dsi83: Add reverse lanes property
> > 
> > This patch adds a boolean property to reverse the LVDS data lanes order for
> > endpoints.
> > 
> > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > [ ... ]
> > > @@ -115,6 +115,10 @@ $defs:
> > >              enum: [100, 200]
> > >              default: 200
> > >  
> > > +          ti,lvds-reverse-lanes:
> > > +            description: Reverse the order of LVDS lanes.
> > > +            type: boolean
> > 
> > [Severity: Low]
> > Is it necessary to introduce a custom vendor-specific boolean property
> > for this?
> > 
> > Since video-interfaces.yaml already provides the standard data-lanes property
> > which can be used to describe the exact lane routing, does this hardware
> > require a distinct property instead of using the standard data-lanes
> > approach with data-lanes = <4 3 2 1>?
> 
> I don't know much about display devices, but this seems like a
> reasonable thing to me. Why would it not work?

It makes perfectly sense. I am working on it already and will send soon V2.