dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage
@ 2026-06-23 10:46 Ben Dooks
  2026-06-23 11:00 ` Boris Brezillon
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Ben Dooks @ 2026-06-23 10:46 UTC (permalink / raw)
  To: Boris Brezillon, Rob Herring, Steven Price, Adrián Larumbe,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Simona Vetter, dri-devel, linux-kernel
  Cc: Ben Dooks

The panfrost_transparent_hugepage variable is declared in panfrost_drv.h
but the panfrost_drv.c does not incldue this header. Fix the following
sparse warning by including panfrost_drv.h :

drivers/gpu/drm/panfrost/panfrost_drv.c:958:6: warning: symbol 'panfrost_transparent_hugepage' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 drivers/gpu/drm/panfrost/panfrost_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
index 784e36d72c2b..36cc2e67a308 100644
--- a/drivers/gpu/drm/panfrost/panfrost_drv.c
+++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
@@ -21,6 +21,7 @@
 #include <drm/drm_utils.h>
 
 #include "panfrost_device.h"
+#include "panfrost_drv.h"
 #include "panfrost_gem.h"
 #include "panfrost_mmu.h"
 #include "panfrost_job.h"
-- 
2.37.2.352.g3c44437643


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage
  2026-06-23 10:46 [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage Ben Dooks
@ 2026-06-23 11:00 ` Boris Brezillon
  2026-06-23 14:57 ` Adrián Larumbe
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Boris Brezillon @ 2026-06-23 11:00 UTC (permalink / raw)
  To: Ben Dooks
  Cc: Rob Herring, Steven Price, Adrián Larumbe, Maarten Lankhorst,
	Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
	dri-devel, linux-kernel

On Tue, 23 Jun 2026 11:46:17 +0100
Ben Dooks <ben.dooks@codethink.co.uk> wrote:

> The panfrost_transparent_hugepage variable is declared in panfrost_drv.h
> but the panfrost_drv.c does not incldue this header. Fix the following
> sparse warning by including panfrost_drv.h :
> 
> drivers/gpu/drm/panfrost/panfrost_drv.c:958:6: warning: symbol 'panfrost_transparent_hugepage' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  drivers/gpu/drm/panfrost/panfrost_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 784e36d72c2b..36cc2e67a308 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -21,6 +21,7 @@
>  #include <drm/drm_utils.h>
>  
>  #include "panfrost_device.h"
> +#include "panfrost_drv.h"
>  #include "panfrost_gem.h"
>  #include "panfrost_mmu.h"
>  #include "panfrost_job.h"


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage
  2026-06-23 10:46 [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage Ben Dooks
  2026-06-23 11:00 ` Boris Brezillon
@ 2026-06-23 14:57 ` Adrián Larumbe
  2026-06-24 15:19 ` Steven Price
  2026-07-10 18:26 ` Adrián Larumbe
  3 siblings, 0 replies; 5+ messages in thread
From: Adrián Larumbe @ 2026-06-23 14:57 UTC (permalink / raw)
  To: Ben Dooks
  Cc: Boris Brezillon, Rob Herring, Steven Price, Adrián Larumbe,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Simona Vetter, dri-devel, linux-kernel

On Tue, 23 Jun 2026 11:46:17 +0100, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage

Reviewed-by: Adrián Larumbe <adrian.larumbe@collabora.com>

-- 
Adrián Larumbe <adrian.larumbe@collabora.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage
  2026-06-23 10:46 [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage Ben Dooks
  2026-06-23 11:00 ` Boris Brezillon
  2026-06-23 14:57 ` Adrián Larumbe
@ 2026-06-24 15:19 ` Steven Price
  2026-07-10 18:26 ` Adrián Larumbe
  3 siblings, 0 replies; 5+ messages in thread
From: Steven Price @ 2026-06-24 15:19 UTC (permalink / raw)
  To: Ben Dooks, Boris Brezillon, Rob Herring, Adrián Larumbe,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Simona Vetter, dri-devel, linux-kernel

On 23/06/2026 11:46, Ben Dooks wrote:
> The panfrost_transparent_hugepage variable is declared in panfrost_drv.h
> but the panfrost_drv.c does not incldue this header. Fix the following
> sparse warning by including panfrost_drv.h :
> 
> drivers/gpu/drm/panfrost/panfrost_drv.c:958:6: warning: symbol 'panfrost_transparent_hugepage' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Reviewed-by: Steven Price <steven.price@arm.com>

> ---
>  drivers/gpu/drm/panfrost/panfrost_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 784e36d72c2b..36cc2e67a308 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -21,6 +21,7 @@
>  #include <drm/drm_utils.h>
>  
>  #include "panfrost_device.h"
> +#include "panfrost_drv.h"
>  #include "panfrost_gem.h"
>  #include "panfrost_mmu.h"
>  #include "panfrost_job.h"


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage
  2026-06-23 10:46 [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage Ben Dooks
                   ` (2 preceding siblings ...)
  2026-06-24 15:19 ` Steven Price
@ 2026-07-10 18:26 ` Adrián Larumbe
  3 siblings, 0 replies; 5+ messages in thread
From: Adrián Larumbe @ 2026-07-10 18:26 UTC (permalink / raw)
  To: Ben Dooks
  Cc: Boris Brezillon, Rob Herring, Steven Price, Maarten Lankhorst,
	Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
	dri-devel, linux-kernel

Queued to drm-misc-next.

On 23.06.2026 11:46, Ben Dooks wrote:
> The panfrost_transparent_hugepage variable is declared in panfrost_drv.h
> but the panfrost_drv.c does not incldue this header. Fix the following
> sparse warning by including panfrost_drv.h :
> 
> drivers/gpu/drm/panfrost/panfrost_drv.c:958:6: warning: symbol 'panfrost_transparent_hugepage' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
>  drivers/gpu/drm/panfrost/panfrost_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 784e36d72c2b..36cc2e67a308 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -21,6 +21,7 @@
>  #include <drm/drm_utils.h>
>  
>  #include "panfrost_device.h"
> +#include "panfrost_drv.h"
>  #include "panfrost_gem.h"
>  #include "panfrost_mmu.h"
>  #include "panfrost_job.h"
> -- 
> 2.37.2.352.g3c44437643

Adrian Larumbe

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-07-10 18:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-23 10:46 [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage Ben Dooks
2026-06-23 11:00 ` Boris Brezillon
2026-06-23 14:57 ` Adrián Larumbe
2026-06-24 15:19 ` Steven Price
2026-07-10 18:26 ` Adrián Larumbe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox