From: Julia Lawall <julia.lawall@lip6.fr>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Rob Herring <robh@kernel.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
"Marty E. Plummer" <hanetzer@startmail.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kbuild-all@01.org
Subject: [PATCH] drm/panfrost: fix odd_ptr_err.cocci warnings
Date: Mon, 1 Apr 2019 21:36:12 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1904012134280.2530@hadrien> (raw)
From: kbuild test robot <lkp@intel.com>
PTR_ERR should access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
Fixes: 10f21de123ac ("drm/panfrost: add support for reset lines")
CC: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git panfrost-rebase-v2
head: 10f21de123ac13b8c257528b0b1222ebb5650510
commit: 10f21de123ac13b8c257528b0b1222ebb5650510 [7/7] drm/panfrost: add support for reset lines
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago
Please take the patch only if it's a positive warning. Thanks!
panfrost_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/gpu/drm/panfrost/panfrost_device.c
+++ b/drivers/gpu/drm/panfrost/panfrost_device.c
@@ -21,7 +21,8 @@ static int panfrost_reset_init(struct pa
pfdev->rstc = devm_reset_control_array_get(pfdev->dev, false, true);
if (IS_ERR(pfdev->rstc)) {
- dev_err(pfdev->dev, "get reset failed %ld\n", PTR_ERR(pfdev->clock));
+ dev_err(pfdev->dev, "get reset failed %ld\n",
+ PTR_ERR(pfdev->rstc));
return PTR_ERR(pfdev->rstc);
}
reply other threads:[~2019-04-01 19:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1904012134280.2530@hadrien \
--to=julia.lawall@lip6.fr \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hanetzer@startmail.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh@kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox