From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: willy@linux.intel.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range
Date: Mon, 21 Apr 2014 14:28:41 -0600 (MDT) [thread overview]
Message-ID: <alpine.OSX.2.00.1404211428060.69402@scrumpy> (raw)
In-Reply-To: <CF7ADB41.27CDE%ross.zwisler@linux.intel.com>
On Wed, 2 Apr 2014, Ross Zwisler wrote:
> With this commit:
>
> 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range
>
> If clflushopt is available on the system, we use it instead of clflush
> in drm_clflush_virt_range. There were two calls to clflush in this
> function, but only one was changed to clflushopt. This patch changes
> the other clflush call to clflushopt.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Reported-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
> ---
> drivers/gpu/drm/drm_cache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
> index 534cb89..041b73b 100644
> --- a/drivers/gpu/drm/drm_cache.c
> +++ b/drivers/gpu/drm/drm_cache.c
> @@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length)
> char *end = addr + length;
> mb();
> for (; addr < end; addr += boot_cpu_data.x86_clflush_size)
> - clflush(addr);
> + clflushopt(addr);
> clflushopt(end - 1);
> mb();
> return;
> --
> 1.7.10.4
Ping? :)
next parent reply other threads:[~2014-04-21 20:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CF7ADB41.27CDE%ross.zwisler@linux.intel.com>
2014-04-21 20:28 ` Ross Zwisler [this message]
2014-04-28 22:57 ` [PATCH] drm: Missed clflushopt in drm_clflush_virt_range David Herrmann
2014-05-14 15:41 Ross Zwisler
2014-05-15 12:38 ` Daniel Vetter
2014-05-15 14:37 ` H. Peter Anvin
2014-05-15 20:40 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2014-04-02 15:28 Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.00.1404211428060.69402@scrumpy \
--to=ross.zwisler@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox