From: Thomas Zimmermann <tzimmermann@suse.de>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 00/12] drm/client: Use after free and debug improvements
Date: Fri, 5 Apr 2024 10:04:03 +0200 [thread overview]
Message-ID: <b07b6eb6-7c7c-4200-9ebd-afe32c6387df@suse.de> (raw)
In-Reply-To: <20240404203336.10454-1-ville.syrjala@linux.intel.com>
Hi
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
for the whole series.
Best regards
Thomas
Am 04.04.24 um 22:33 schrieb Ville Syrjala:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Various improvements to the drm/client code:
> - Fix a use after free (fairly routinely hit by i915 CI)
> - Debug print improvements
> - Cleanups/etc.
>
> Ville Syrjälä (12):
> drm/client: Fully protect modes[] with dev->mode_config.mutex
> drm/client:
> s/drm_connector_has_preferred_mode/drm_connector_preferred_mode/
> drm/client: Use drm_mode_destroy()
> drm/client: Add a FIXME around crtc->mode usage
> drm/client: Nuke outdated fastboot comment
> drm/client: Constify modes
> drm/client: Use array notation for function arguments
> drm/client: Extract drm_connector_first_mode()
> drm/client: Switch to per-device debugs
> drm/client: Use [CONNECTOR:%d:%s] formatting
> drm/client: Streamline mode selection debugs
> drm/probe-helper: Switch to per-device debugs
>
> drivers/gpu/drm/drm_client_modeset.c | 237 ++++++++++++++-------------
> drivers/gpu/drm/drm_probe_helper.c | 35 ++--
> 2 files changed, 137 insertions(+), 135 deletions(-)
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
prev parent reply other threads:[~2024-04-05 8:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 20:33 [PATCH 00/12] drm/client: Use after free and debug improvements Ville Syrjala
2024-04-04 20:33 ` [PATCH 01/12] drm/client: Fully protect modes[] with dev->mode_config.mutex Ville Syrjala
2024-04-05 3:24 ` Dmitry Baryshkov
2024-04-05 19:17 ` Ville Syrjälä
2024-04-05 20:39 ` Dmitry Baryshkov
2024-04-05 20:57 ` Ville Syrjälä
2024-04-04 20:33 ` [PATCH 02/12] drm/client: s/drm_connector_has_preferred_mode/drm_connector_preferred_mode/ Ville Syrjala
2024-04-05 3:27 ` Dmitry Baryshkov
2024-04-04 20:33 ` [PATCH 03/12] drm/client: Use drm_mode_destroy() Ville Syrjala
2024-04-05 3:28 ` Dmitry Baryshkov
2024-04-04 20:33 ` [PATCH 04/12] drm/client: Add a FIXME around crtc->mode usage Ville Syrjala
2024-04-05 3:32 ` Dmitry Baryshkov
2024-04-05 19:40 ` Ville Syrjälä
2024-04-04 20:33 ` [PATCH 05/12] drm/client: Nuke outdated fastboot comment Ville Syrjala
2024-04-05 3:33 ` Dmitry Baryshkov
2024-04-04 20:33 ` [PATCH 06/12] drm/client: Constify modes Ville Syrjala
2024-04-05 7:01 ` kernel test robot
2024-04-06 21:59 ` kernel test robot
2024-04-04 20:33 ` [PATCH 07/12] drm/client: Use array notation for function arguments Ville Syrjala
2024-04-05 8:02 ` Thomas Zimmermann
2024-04-04 20:33 ` [PATCH 08/12] drm/client: Extract drm_connector_first_mode() Ville Syrjala
2024-04-05 8:26 ` Jani Nikula
2024-04-04 20:33 ` [PATCH 09/12] drm/client: Switch to per-device debugs Ville Syrjala
2024-04-04 20:33 ` [PATCH 10/12] drm/client: Use [CONNECTOR:%d:%s] formatting Ville Syrjala
2024-04-05 8:23 ` Jani Nikula
2024-04-05 20:12 ` Ville Syrjälä
2024-04-04 20:33 ` [PATCH 11/12] drm/client: Streamline mode selection debugs Ville Syrjala
2024-04-05 7:49 ` Thomas Zimmermann
2024-04-05 7:57 ` Thomas Zimmermann
2024-04-05 19:58 ` Ville Syrjälä
2024-04-08 7:46 ` Thomas Zimmermann
2024-04-08 17:26 ` Ville Syrjälä
2024-04-09 8:01 ` Thomas Zimmermann
2024-04-04 20:33 ` [PATCH 12/12] drm/probe-helper: Switch to per-device debugs Ville Syrjala
2024-04-05 8:25 ` Jani Nikula
2024-04-05 8:30 ` Thomas Zimmermann
2024-04-05 8:04 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b07b6eb6-7c7c-4200-9ebd-afe32c6387df@suse.de \
--to=tzimmermann@suse.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox