From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, dri-devel@lists.freedesktop.org
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [PATCH] intel: Do not assert on unknown chips in drm_intel_decode_context_alloc
Date: Thu, 19 Nov 2020 13:42:07 +0000 [thread overview]
Message-ID: <b8438d8f-bc6b-921d-adb2-cd6e25d70bdb@linux.intel.com> (raw)
In-Reply-To: <160571907017.19853.2138891452982731448@build.alporthouse.com>
On 18/11/2020 17:04, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2020-11-18 16:36:01)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> There is this long standing nit of igt/tools/intel_error_decode asserting
>> when you feed it an error state from a GPU the local libdrm does not know
>> of.
>>
>> To fix this I need a tweak in drm_intel_decode_context_alloc to make it
>> not assert but just return NULL (which seems an already possible return
>> value).
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Good riddance,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks, now how can push to drm and is there some testing to be
triggered before, or after?
Regards,
Tvrtko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-19 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 16:36 [PATCH] intel: Do not assert on unknown chips in drm_intel_decode_context_alloc Tvrtko Ursulin
2020-11-18 17:04 ` Chris Wilson
2020-11-19 13:42 ` Tvrtko Ursulin [this message]
2020-11-19 13:52 ` Chris Wilson
2020-11-19 13:58 ` Tvrtko Ursulin
2021-06-17 9:20 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8438d8f-bc6b-921d-adb2-cd6e25d70bdb@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox