Re: [PATCH] intel: Do not assert on unknown chips in drm_intel_decode_context_alloc

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 19/11/2020 13:52, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2020-11-19 13:42:07)
>>
>> On 18/11/2020 17:04, Chris Wilson wrote:
>>> Quoting Tvrtko Ursulin (2020-11-18 16:36:01)
>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>
>>>> There is this long standing nit of igt/tools/intel_error_decode asserting
>>>> when you feed it an error state from a GPU the local libdrm does not know
>>>> of.
>>>>
>>>> To fix this I need a tweak in drm_intel_decode_context_alloc to make it
>>>> not assert but just return NULL (which seems an already possible return
>>>> value).
>>>>
>>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>
>>> Good riddance,
>>> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>>
>> Thanks, now how can push to drm and is there some testing to be
>> triggered before, or after?
> 
> cd intel; for i in tests/gen*.sh; do $i; done
> 
> But clearly I haven't built libdrm since automake was dropped.

Thanks, all good:

$ for t in ../../intel/tests/gen*.sh; do bash -x $t; done
++ echo ../../intel/tests/gen4-3d.batch.sh
++ sed 's|\.sh$||'
+ TEST_FILENAME=../../intel/tests/gen4-3d.batch
+ ./test_decode ../../intel/tests/gen4-3d.batch
+ ret=0
+ test 0 = 1
+ exit 0
++ echo ../../intel/tests/gen5-3d.batch.sh
++ sed 's|\.sh$||'
+ TEST_FILENAME=../../intel/tests/gen5-3d.batch
+ ./test_decode ../../intel/tests/gen5-3d.batch
+ ret=0
+ test 0 = 1
+ exit 0
++ echo ../../intel/tests/gen6-3d.batch.sh
++ sed 's|\.sh$||'
+ TEST_FILENAME=../../intel/tests/gen6-3d.batch
+ ./test_decode ../../intel/tests/gen6-3d.batch
+ ret=0
+ test 0 = 1
+ exit 0
++ echo ../../intel/tests/gen7-2d-copy.batch.sh
++ sed 's|\.sh$||'
+ TEST_FILENAME=../../intel/tests/gen7-2d-copy.batch
+ ./test_decode ../../intel/tests/gen7-2d-copy.batch
+ ret=0
+ test 0 = 1
+ exit 0
++ echo ../../intel/tests/gen7-3d.batch.sh
++ sed 's|\.sh$||'
+ TEST_FILENAME=../../intel/tests/gen7-3d.batch
+ ./test_decode ../../intel/tests/gen7-3d.batch
+ ret=0
+ test 0 = 1
+ exit 0

Regards,

Tvrtko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel