dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sunran001@208suo.com
To: airlied@gmail.com, daniel@ffwll.ch
Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: [PATCH] drm/nouveau/volt/gk104: Move assignment outside if condition
Date: Tue, 11 Jul 2023 10:31:44 +0800	[thread overview]
Message-ID: <bd3bd7ec598a7858fc0a90619eedd0ca@208suo.com> (raw)
In-Reply-To: <20230711022942.78260-1-xujianghui@cdjrlc.com>

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]


Fixes the following checkpatch errors:

ERROR: do not use assignment in if condition

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c 
b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
index d1ce4309cfb8..35ab4fa5d18e 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
@@ -113,7 +113,8 @@ gk104_volt_new(struct nvkm_device *device, enum 
nvkm_subdev_type type, int inst,
          volt_func = &gk104_volt_pwm;
      }

-    if (!(volt = kzalloc(sizeof(*volt), GFP_KERNEL)))
+    volt = kzalloc(sizeof(*volt), GFP_KERNEL);
+    if (!volt)
          return -ENOMEM;
      nvkm_volt_ctor(volt_func, device, type, inst, &volt->base);
      *pvolt = &volt->base;

[-- Attachment #2: Type: text/html, Size: 1548 bytes --]

           reply	other threads:[~2023-07-11  2:31 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20230711022942.78260-1-xujianghui@cdjrlc.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd3bd7ec598a7858fc0a90619eedd0ca@208suo.com \
    --to=sunran001@208suo.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox