* [PATCH] drm/nouveau/volt/gk104: Move assignment outside if condition
[not found] <20230711022942.78260-1-xujianghui@cdjrlc.com>
@ 2023-07-11 2:31 ` sunran001
0 siblings, 0 replies; only message in thread
From: sunran001 @ 2023-07-11 2:31 UTC (permalink / raw)
To: airlied, daniel; +Cc: nouveau, linux-kernel, dri-devel
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
index d1ce4309cfb8..35ab4fa5d18e 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
@@ -113,7 +113,8 @@ gk104_volt_new(struct nvkm_device *device, enum
nvkm_subdev_type type, int inst,
volt_func = &gk104_volt_pwm;
}
- if (!(volt = kzalloc(sizeof(*volt), GFP_KERNEL)))
+ volt = kzalloc(sizeof(*volt), GFP_KERNEL);
+ if (!volt)
return -ENOMEM;
nvkm_volt_ctor(volt_func, device, type, inst, &volt->base);
*pvolt = &volt->base;
[-- Attachment #2: Type: text/html, Size: 1548 bytes --]
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-07-11 2:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230711022942.78260-1-xujianghui@cdjrlc.com>
2023-07-11 2:31 ` [PATCH] drm/nouveau/volt/gk104: Move assignment outside if condition sunran001
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox