[Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows

[bugzilla-daemon@freedesktop.org]

[-- Attachment #1.1: Type: text/plain, Size: 1546 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106175

--- Comment #59 from bmilreu@gmail.com ---
(In reply to Nicholas Kazlauskas from comment #58)
> (In reply to Brandon Wright from comment #55)
> > Created attachment 142558 [details] [review] [review]
> > Patch that "fixes" the problem.
> > 
> > I've attached a patch that fixes the problem for me. It copies parts from
> > the intel patch and uses the existing async infrastructure for the cursor. 
> > 
> > It's really tiny, so I hope this is helpful enough to get this problem fixed
> > quick.
> 
> This is a nice attempt but it only resolves the problem because it relies on
> the blocking behavior in atomic check that amdgpu_dm currently does (and
> shouldn't be doing).
> 
> Asynchronous updates can and will occur in parallel with other commits on
> worker threads. Without the wait in atomic_check you'll see the IGT legacy
> cursor tests break with this patch (and there will probably be system faults
> as well).
> 
> There are larger problems within amdgpu_dm's commit tail that if addressed
> should resolve this issue for compton I'd imagine.

Since you've been working on Freesync, you should know your patches are also
affected by this bug on some wine games. Any chance you could you kindly try to
tackle this? 

btw, I don't have igt on my system atm, nor got any system fault yet with the
patch. I really need dc for the extra headphone jack, mine is broken atm :(

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2894 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel