dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 107115] Make darktable OpenCL support work on Clover and RadeonSI
Date: Wed, 04 Jul 2018 19:30:29 +0000	[thread overview]
Message-ID: <bug-107115-502@http.bugs.freedesktop.org/> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 2263 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107115

            Bug ID: 107115
           Summary: Make darktable OpenCL support work on Clover and
                    RadeonSI
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: FreeBSD
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: greg@unrelenting.technology
        QA Contact: dri-devel@lists.freedesktop.org

Hi everyone, I've tried to get the darktable photo editor
https://www.darktable.org to work, and there's more to it than image support...

First, I've picked up funfunctor's patches (mentioned in bug 99553), they
applied cleanly to master (except for the little one-line "= 1" since the
r600/radeonsi split happened, but that was trivial to fix). My branch with them
is https://github.com/myfreeweb/mesa/tree/clover-image

Second, there was some weird mismatch between libclc's headers and darktable's
code, and I've had to do:

%s/write_only image2d_t/image2d_t

and

%s/__image2d_t/image2d_t

on all files in PREFIX/share/darktable/kernels.

Third, the liquify.cl kernel triggered the
https://bugs.llvm.org/show_bug.cgi?id=36679 crash (which is fixed in llvm 7...
but I just removed the function body to proceed without this particular effect)

And finally, with all kernels compiled, darktable benchmarked CPU vs GPU and
found the CPU to be a bit faster (yay for Ryzen) and disabled OpenCL usage.

Enabling OpenCL usage in the settings and then double clicking on an image...
uhh... hard locked the GPU :D

drmn0: GPU fault detected: 147 0x05004402
drmn0:   VM_CONTEXT1_PROTECTION_FAULT_ADDR   0x005000A0
drmn0:   VM_CONTEXT1_PROTECTION_FAULT_STATUS 0x08044002
drmn0: VM fault (0x02, vmid 4) at page 5243040, read from 'TC5' (0x54433500)
(68)

P.S. system info: AMD Radeon RX 480, FreeBSD 12-CURRENT / drm-next-kmod 4.15
(DRM 3.23.0) with amdgpu.dc=1, LLVM 6.0.0, Mesa with patches on top of git rev
c2ae9b4052701, libclc git rev c45b9dfe5257, darktable 2.4.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3958 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2018-07-04 19:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 19:30 bugzilla-daemon [this message]
2018-07-04 19:30 ` [Bug 107115] Make darktable OpenCL support work on Clover and RadeonSI bugzilla-daemon
2018-07-04 19:39 ` bugzilla-daemon
2018-07-04 22:02 ` bugzilla-daemon
2018-09-09 22:35 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107115-502@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox