From: bugzilla-daemon@bugzilla.kernel.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 215001] Regression in 5.15, Firmware-initialized graphics console selects FB_VGA16, screen corruption
Date: Fri, 07 Jan 2022 02:16:50 +0000 [thread overview]
Message-ID: <bug-215001-2300-IH2XzuPbew@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-215001-2300@https.bugzilla.kernel.org/>
https://bugzilla.kernel.org/show_bug.cgi?id=215001
--- Comment #5 from Javier Martinez Canillas (javier@dowhile0.org) ---
Created attachment 300235
--> https://bugzilla.kernel.org/attachment.cgi?id=300235&action=edit
[PATCH] video: vga16fb: Only probe for EGA and VGA 16 color graphic cards
Can you try the attached (untested) patch?
The commit you mention in Comment 3 didn't change any logic but just moved the
platform device registration that match the vesafb and efifb drivers.
As far as I can tell, the problem is that the vga16fb driver doesn't check if
the video modes are one that's supported by it and just blindly attempts to
probe the driver.
This probably wasn't a problem before because the sysfb.o was in
arch/x86/kernel but no is in drivers/firmware. But the issue in vga16fb was
present before, just moving exposed it.
I believe that the correct thing is to check if screen_info says that's a
{E,V}GA 16 color mode and fail to probe the vga16fb driver otherwise.
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2022-01-07 2:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-215001-2300@https.bugzilla.kernel.org/>
2021-11-16 9:56 ` [Bug 215001] Regression in 5.15, Firmware-initialized graphics console selects FB_VGA16, screen corruption bugzilla-daemon
2021-11-16 9:57 ` bugzilla-daemon
2022-01-06 2:39 ` bugzilla-daemon
2022-01-06 15:16 ` bugzilla-daemon
2022-01-07 2:16 ` bugzilla-daemon [this message]
2022-01-07 2:24 ` bugzilla-daemon
2022-01-07 7:52 ` bugzilla-daemon
2022-01-07 11:13 ` bugzilla-daemon
2022-01-07 11:31 ` bugzilla-daemon
2022-01-07 23:12 ` bugzilla-daemon
2022-01-08 11:16 ` bugzilla-daemon
2022-01-11 9:50 ` bugzilla-daemon
2022-01-12 2:14 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-215001-2300-IH2XzuPbew@https.bugzilla.kernel.org/ \
--to=bugzilla-daemon@bugzilla.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox