dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 2377] Polygon stipple broken.
Date: Thu, 17 Jan 2013 17:44:09 +0000	[thread overview]
Message-ID: <bug-2377-502-ERhfMdhy3q@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-2377-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 934 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=2377

--- Comment #7 from Roland Scheidegger <sroland@vmware.com> ---
Looks to me like the offsets for the stipple pattern are wrong.
These are set in r200UpdateViewportOffset - which has no callers. I noted this
in bug 57842, and tried to address it there though the patch probably wasn't
really right in any case, but you could try that as a starting point.
(I'm not sure though if actually we don't also need to take viewport into
account for the offsets? Maybe not though. I'm pretty sure though stippling
also additionally would be broken for fbo's (but certainly should go unnoticed
by this test), as the code does as the comment says, always invert the
stippling pattern, and the y offset is also always calculated taking the window
height into account, and I strongly suspect both aren't right for fbos.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1835 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2013-01-17 17:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-2377-502@http.bugs.freedesktop.org/>
2013-01-11 14:33 ` [Bug 2377] Polygon stipple broken bugzilla-daemon
2013-01-11 15:29 ` bugzilla-daemon
2013-01-11 15:31 ` bugzilla-daemon
2013-01-11 15:34 ` bugzilla-daemon
2013-01-11 15:35 ` bugzilla-daemon
2013-01-17 17:44 ` bugzilla-daemon [this message]
2013-01-17 18:20 ` bugzilla-daemon
2013-01-17 19:14 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-2377-502-ERhfMdhy3q@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox