dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 73191] [radeonsi] vdpau playback issues, skipping & looping
Date: Mon, 24 Feb 2014 19:28:38 +0000	[thread overview]
Message-ID: <bug-73191-502-iD5Zs3xQK6@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-73191-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 2188 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=73191

Andreas Boll <andreas.boll.dev@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #42 from Andreas Boll <andreas.boll.dev@gmail.com> ---
Fixed with the following commits:

commit 3f98053fc94a964930c73c43154daddfd7824e7c
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Mon Jan 13 14:13:01 2014 +0100

    vdpau: flush the context before exporting the surface v2

    Bugzilla (bug needs XBMC changes as well):
    https://bugs.freedesktop.org/show_bug.cgi?id=73191

    When VL uploads vertex buffers, it uses PIPE_TRANSFER_DONTBLOCK, which
always
    flushes the context in the winsys if the buffer being mapped is busy. Since
    I added handling of DISCARD_RANGE, DONTBLOCK has had no effect when
combined
    with DISCARD_RANGE and I think the context isn't flushed anywhere else,
    so no commands are submitted to the GPU until the IB is full, which takes
    a lot of frames.

    Using DISCARD_RANGE is not the only way to trigger this bug. The other way
    is to reallocate the vertex buffer before every upload.

    BTW, I'm not sure if this is the right place for flushing, but it does fix
    the bug.

    v2 (chk): move the flush to the right place.

    Signed-off-by: Christian König <christian.koenig@amd.com>
    Tested-by: StrangeNoises (rachel@strangenoises.org)


commit db54fca9b86aa124447d11d2bdbe359a2742cfd5
Author: Christian König <christian.koenig@amd.com>
Date:   Tue Jan 28 15:22:05 2014 +0100

    st/vdpau: add flush on unmap

    Flush the context when we unmap a buffer, otherwise VDPAU might
    start rendering the next frame while we still reference that buffer.

    Signed-off-by: Christian König <christian.koenig@amd.com>
    Tested-by: StrangeNoises (rachel@strangenoises.org)


Additionally cherry-picked to 10.1 branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 4257 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2014-02-24 19:28 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-31 18:32 [Bug 73191] New: [radeonsi] vdpau playback issues, skipping & looping bugzilla-daemon
2014-01-09  4:28 ` [Bug 73191] " bugzilla-daemon
2014-01-10  1:58 ` bugzilla-daemon
2014-01-10  8:51 ` bugzilla-daemon
2014-01-10 11:05 ` bugzilla-daemon
2014-01-10 11:24 ` bugzilla-daemon
2014-01-10 11:42 ` bugzilla-daemon
2014-01-10 18:50 ` bugzilla-daemon
2014-01-10 19:18 ` bugzilla-daemon
2014-01-10 19:38 ` bugzilla-daemon
2014-01-11 10:21 ` bugzilla-daemon
2014-01-11 11:22 ` bugzilla-daemon
2014-01-11 11:45 ` bugzilla-daemon
2014-01-11 11:55 ` bugzilla-daemon
2014-01-11 16:21 ` bugzilla-daemon
2014-01-11 19:06 ` bugzilla-daemon
2014-01-11 19:16 ` bugzilla-daemon
2014-01-11 19:33 ` bugzilla-daemon
2014-01-11 19:35 ` bugzilla-daemon
2014-01-11 19:40 ` bugzilla-daemon
2014-01-11 19:41 ` bugzilla-daemon
2014-01-12  0:56 ` bugzilla-daemon
2014-01-12  7:11 ` bugzilla-daemon
2014-01-12 14:51 ` bugzilla-daemon
2014-01-28  3:44 ` bugzilla-daemon
2014-01-28 12:02 ` bugzilla-daemon
2014-01-28 12:06 ` bugzilla-daemon
2014-01-28 13:07 ` bugzilla-daemon
2014-01-28 13:47 ` bugzilla-daemon
2014-01-28 13:58 ` bugzilla-daemon
2014-01-28 22:37 ` bugzilla-daemon
2014-02-04  6:59 ` bugzilla-daemon
2014-02-04 12:02 ` bugzilla-daemon
2014-02-09 17:29 ` bugzilla-daemon
2014-02-10 20:27 ` bugzilla-daemon
2014-02-11  8:57 ` bugzilla-daemon
2014-02-11 12:05 ` bugzilla-daemon
2014-02-11 12:10 ` bugzilla-daemon
2014-02-11 12:16 ` bugzilla-daemon
2014-02-11 12:26 ` bugzilla-daemon
2014-02-11 12:48 ` bugzilla-daemon
2014-02-12 20:01 ` bugzilla-daemon
2014-02-24 19:28 ` bugzilla-daemon [this message]
2014-02-25  9:36 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-73191-502-iD5Zs3xQK6@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox