[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1841 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

            Bug ID: 88561
           Summary: [radeonsi][regression,bisected] Depth test/buffer
                    issues in Portal
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: daniel@constexpr.org

Created attachment 112428
  --> https://bugs.freedesktop.org/attachment.cgi?id=112428&action=edit
Bad frame

With current Mesa master (commit 461103ef64858e9d81073fad1bd8222b70b2754b),
(some) background geometry will be randomly drawn above foreground for some
frames in Portal (also observed in the Portal mod Rexaura). It does not happen
often and the same scene may be fine depending on what was loaded before or
just randomness.

Bisecting blames commit 02ba7334d35cf8182048c17a149b16f18104c6bf
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Sun Jan 4 22:16:53 2015 +0100

    radeonsi: don't use TC L2 for updating descriptors on SI

    It's causing problems, because we mix uncached CP DMA with cached
WRITE_DATA
    when updating the same memory.

    The solution for SI is to use uncached access here, because CP DMA doesn't
    support cached access.

    CIK will be handled in the next patch.

    Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>

Simply reverting this commit on master causes other rendering issues.

GPU: Radeon HD 7950 (OpenGL renderer string: Gallium 0.4 on AMD TAHITI)
LLVM compiled from svn last week (r225584)
GCC: 4.8.4
Kernel: Linux 3.18.2-gentoo
Distro: Gentoo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3361 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 419 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

Daniel Scharrer <daniel@constexpr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112428|text/plain                  |image/jpeg
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1090 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 300 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

--- Comment #1 from Daniel Scharrer <daniel@constexpr.org> ---
Created attachment 112429
  --> https://bugs.freedesktop.org/attachment.cgi?id=112429&action=edit
Good frame

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1216 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 356 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

--- Comment #2 from Marek Olšák <maraeo@gmail.com> ---
Does the issue occur in any freely-available Steam game like Team Fortress 2
and DOTA 2? If not, could you please create an apitrace file reproducing the
issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1173 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 816 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

--- Comment #3 from Daniel Scharrer <daniel@constexpr.org> ---
Created attachment 113176
  --> https://bugs.freedesktop.org/attachment.cgi?id=113176&action=edit
Vertex issues in TF2

I've re-tested Portal with updated mesa (commit
2335153ff2fae01d6294876a86d3eab59c6c4236) and kernel (3.18.5-gentoo) and the
issue is still there.

There also seems to be a rendering regression with TF2 for me, but it looks
different. Where in Portal objects appear in front of others that they should
be behind of, in TF 2 they disappear entirely or appear to have garbage
vertices. I haven't yet tested that the TF2 issues were introduced in the same
commit.

I'll create apitraces of both later today.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1752 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 375 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

--- Comment #4 from Daniel Scharrer <daniel@constexpr.org> ---
Here is an apitrace from portal that consistently triggers the bug for me
(however, which frames are misrendered varies):

 http://constexpr.org/tmp/Portal-radeonsi.trace.xz (193 MiB)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1242 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 428 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113176|text/plain                  |image/jpeg
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1119 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 794 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

--- Comment #5 from Daniel Scharrer <daniel@constexpr.org> ---
For some reason this happens a lot less frequently now than it used to. With

Mesa git-8a71fd8
LLVM r229671
Kernel 3.19.0-gentoo

I need to re-run the apitrace multiple times before triggering the bug, while
before there were many bad frames per run.

There are also other rendering errors in Portal that look more like the ones I
get in TF2 - I guess those are more likely to be related to 88978.

I'm not sure what changed - the bug still happens infrequently when reverting
to either Linux 3.18.6-gentoo or to Mesa git-2335153. Either way, the bug is
still there, just a lot harder to reproduce now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1597 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 375 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

--- Comment #6 from Marek Olšák <maraeo@gmail.com> ---
Created attachment 113659
  --> https://bugs.freedesktop.org/attachment.cgi?id=113659&action=edit
possible fix

Please test this patch. It seems to fix the bug for the apitrace.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1393 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 488 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

--- Comment #7 from Lorenzo Bona <lorenz.bona@gmail.com> ---
(In reply to Marek Olšák from comment #6)
> Created attachment 113659 [details] [review]
> possible fix
> 
> Please test this patch. It seems to fix the bug for the apitrace.

Thank you Marek.

Your patch fix this bug https://bugs.freedesktop.org/show_bug.cgi?id=88978 too.
Nice.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1814 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 766 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

--- Comment #8 from Daniel Scharrer <daniel@constexpr.org> ---
Hi Marek,

the patch does improve things a lot: with it I can no longer reproduce any
glitches in my Portal trace or in the Dota 2 trace from bug 88978 comment 2.
However, in-game some glitches remain.

In Portal they are extremely infrequent with your patch, however disappearing
terrain patches and garbage vertices are still relatively easy to reproduce in
Team Fortress 2. (Maybe this fits belongs in bug 88978?) I tried to record an
apitrace of TF2 but it does not replay correctly. Just loading up a practice
map (I tried Dustbowl) and walking around should be enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1890 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 459 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

Daniel Scharrer <daniel@constexpr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.freedesktop.or
                   |                            |g/show_bug.cgi?id=89228

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1122 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 459 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

Daniel Scharrer <daniel@constexpr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.freedesktop.or
                   |                            |g/show_bug.cgi?id=88978

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1122 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 831 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

--- Comment #9 from Daniel Scharrer <daniel@constexpr.org> ---
Created attachment 115651
  --> https://bugs.freedesktop.org/attachment.cgi?id=115651&action=edit
Junk rendered in The Talos Principle

This still happens in various Source engine games (and perhaps elsewhere), just
not as frequently.

The The Talos Principle trace from bug 87278 comment 29 has some garbage being
rendered (screenshot attached) that looks similar to what I get in Source
engine games, but it is much easier to reproduce:

 http://constexpr.org/tmp/Talos-radeonsi.3.trace.xz (147 MiB)

No idea of that is the same bug or even if the current Source engine issue is
related to the original Portal bug I bisected in this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2056 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 88561] [radeonsi][regression, bisected] Depth test/buffer issues in Portal

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 679 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=88561

Daniel Scharrer <daniel@constexpr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Daniel Scharrer <daniel@constexpr.org> ---
I think Marek's patch fixed the original Portal issue I bisected in radeonsi.
The remakning glitches seem to be caused by a LLVM regression. I've added the
relevant information to bug #88978.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2361 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel