dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 99349] Failed to build shader (translation from TGSI)
Date: Fri, 26 May 2017 13:31:12 +0000	[thread overview]
Message-ID: <bug-99349-502-3q714GPtNm@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-99349-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 1366 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99349

--- Comment #9 from Gert Wollny <gw.fossdev@gmail.com> ---
It turns out that in r600_shader.c:tgsi_split_constant the constants should be
moved to the GPR range, but for large shaders this is not sufficient, since the
temporary registers used there may be beyond 127 which is the limit for GPRs. 

tgsi_split_constant doesn't move all constants and if an operator uses the same
constant as source more than once, then one of the instances of the constants
is moved to a new address, and this may even be counter productive. 

Now to fix this bug, a partial workaround is in the repo I've given above, the
patch changes the register handling to reserve a few registers in the low range
and moves constants there if necessary. Note, however, that it also contains
additional debugging output. 

However, for the instruction 

 LRP TEMP[0].xyz, CONST[31].wwww, CONST[31].xyzz, TEMP[0].xyzz

check_and_set_bank_swizzle still fails. (This is, by the way, one such case
where 
tgsi_split_constant moves one of the instances of CONST[31] to another place.) 

I will try to correct  tgsi_split_constant to not move the values around if
they are originally from the same source and see whether this fixes the
problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2141 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-05-26 13:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 17:24 [Bug 99349] Failed to build shader (translation from TGSI) bugzilla-daemon
2017-01-10 17:44 ` bugzilla-daemon
2017-05-17  6:45 ` bugzilla-daemon
2017-05-24 13:10 ` bugzilla-daemon
2017-05-24 14:56 ` bugzilla-daemon
2017-05-25  8:10 ` bugzilla-daemon
2017-05-25  9:32 ` bugzilla-daemon
2017-05-26  9:01 ` bugzilla-daemon
2017-05-26  9:03 ` bugzilla-daemon
2017-05-26 13:31 ` bugzilla-daemon [this message]
2017-05-26 20:24 ` bugzilla-daemon
2017-05-29 13:28 ` bugzilla-daemon
2017-06-02 17:55 ` bugzilla-daemon
2017-06-25 22:29 ` bugzilla-daemon
2017-06-26  6:03 ` bugzilla-daemon
2017-06-26 13:41 ` bugzilla-daemon
2017-07-11 23:07 ` bugzilla-daemon
2017-07-16 21:17 ` bugzilla-daemon
2017-09-08  5:56 ` bugzilla-daemon
2017-09-08 11:05 ` bugzilla-daemon
2018-03-26 13:13 ` bugzilla-daemon
2018-03-26 18:26 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99349-502-3q714GPtNm@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox