dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
	Thomas Zimmermann <tzimmermann@suse.de>
Cc: airlied@linux.ie, sam@ravnborg.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/vram-helper: Alternate between bottom-up and top-down placement
Date: Thu, 23 Apr 2020 17:04:31 +0200	[thread overview]
Message-ID: <c592baa1-7e0f-688e-1e31-bb7c8c28d8fa@amd.com> (raw)
In-Reply-To: <20200423135709.3yuafqt3xouka4jp@sirius.home.kraxel.org>

Hi guys,

one thing you don't seem to have considered yet is that not setting the 
top-down flag also won't get you the bottom-up approach, but rather the 
best fit.

Additional to that the top-down allocations have quite a bit more CPU 
overhead since they don't walk the size tree, but the address tree in 
search for a fitting hole. Nirmoy is currently working on improving this.

Am 23.04.20 um 15:57 schrieb Gerd Hoffmann:
>> But cursor BOs are small, so they don't make much of a difference. What
>> is needed is space for 2 primary framebuffers during pageflips, with one
>> of them pinned. The other framebuffer can be located anywhere.
> The problem isn't the size.  The problem is dynamically allocated cursor
> BOs can also fragment vram, especially if top-bottom allocation is also
> used for large framebuffers so cursor BOs can end up somewhere in the
> middle of vram.

Well maybe instead of a ping/pong approach between top and bottom use a 
size based approach to place small BOs at the top and only the larger 
ones at the bottom (or the other way around).

Cheers,
Christian.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-04-23 15:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 14:40 [PATCH 0/2] drm/vram-helper: Reduce memory fragmentation Thomas Zimmermann
2020-04-22 14:40 ` [PATCH 1/2] drm/vram-helper: Don't put new BOs into VRAM Thomas Zimmermann
2020-04-22 14:40 ` [PATCH 2/2] drm/vram-helper: Alternate between bottom-up and top-down placement Thomas Zimmermann
2020-04-23 11:18   ` Gerd Hoffmann
2020-04-23 12:44     ` Thomas Zimmermann
2020-04-23 13:57       ` Gerd Hoffmann
2020-04-23 15:04         ` Christian König [this message]
2020-04-24  6:27           ` Thomas Zimmermann
2020-04-24  6:56             ` Christian König
2020-04-24  7:03               ` Thomas Zimmermann
2020-04-24  7:39                 ` Christian König
2020-04-24  6:59         ` Thomas Zimmermann
2020-04-24  9:38           ` Gerd Hoffmann
2020-04-28 15:16             ` Thomas Zimmermann
2020-04-29  7:25               ` Gerd Hoffmann
2020-04-29  9:11                 ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c592baa1-7e0f-688e-1e31-bb7c8c28d8fa@amd.com \
    --to=christian.koenig@amd.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox