dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Andrzej Hajda <a.hajda@samsung.com>, Inki Dae <inki.dae@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	dri-devel@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] drm/exynos/hdmi: fix disable sequence
Date: Wed, 12 Jul 2017 12:31:43 +0200	[thread overview]
Message-ID: <ce49d672-5bee-86ef-24cc-7ebdd76ee9f2@samsung.com> (raw)
In-Reply-To: <1499853683-10261-1-git-send-email-a.hajda@samsung.com>

Hi

On 2017-07-12 12:01, Andrzej Hajda wrote:
> The "Fixes" patch was incorrectly merged, as a result PHY is prematurely
> powered off and for example Odroid-U3 cannot disable TV power domain
> when HDMI cable is unplugged.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Fixes: 625e63e2 ("drm/exynos/hdmi: fix pipeline disable order")~

This patch finally fixes the 'Power domain TV disable failed' issue in 
linux-next.

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---
>   drivers/gpu/drm/exynos/exynos_hdmi.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index e65cdbf..b1718d8 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -1501,8 +1501,6 @@ static void hdmi_disable(struct drm_encoder *encoder)
>   	 */
>   	cancel_delayed_work(&hdata->hotplug_work);
>   	cec_notifier_set_phys_addr(hdata->notifier, CEC_PHYS_ADDR_INVALID);
> -
> -	hdmiphy_disable(hdata);
>   }
>   
>   static const struct drm_encoder_helper_funcs exynos_hdmi_encoder_helper_funcs = {

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

      reply	other threads:[~2017-07-12 10:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170712100130eucas1p28e5dd505bee3f5e7f09d81bab8e5ba06@eucas1p2.samsung.com>
2017-07-12 10:01 ` [PATCH] drm/exynos/hdmi: fix disable sequence Andrzej Hajda
2017-07-12 10:31   ` Marek Szyprowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce49d672-5bee-86ef-24cc-7ebdd76ee9f2@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=a.hajda@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox