dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/exynos/hdmi: fix disable sequence
       [not found] <CGME20170712100130eucas1p28e5dd505bee3f5e7f09d81bab8e5ba06@eucas1p2.samsung.com>
@ 2017-07-12 10:01 ` Andrzej Hajda
  2017-07-12 10:31   ` Marek Szyprowski
  0 siblings, 1 reply; 2+ messages in thread
From: Andrzej Hajda @ 2017-07-12 10:01 UTC (permalink / raw)
  To: Inki Dae
  Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
	dri-devel, linux-samsung-soc

The "Fixes" patch was incorrectly merged, as a result PHY is prematurely
powered off and for example Odroid-U3 cannot disable TV power domain
when HDMI cable is unplugged.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Fixes: 625e63e2 ("drm/exynos/hdmi: fix pipeline disable order")
---
 drivers/gpu/drm/exynos/exynos_hdmi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index e65cdbf..b1718d8 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -1501,8 +1501,6 @@ static void hdmi_disable(struct drm_encoder *encoder)
 	 */
 	cancel_delayed_work(&hdata->hotplug_work);
 	cec_notifier_set_phys_addr(hdata->notifier, CEC_PHYS_ADDR_INVALID);
-
-	hdmiphy_disable(hdata);
 }
 
 static const struct drm_encoder_helper_funcs exynos_hdmi_encoder_helper_funcs = {
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/exynos/hdmi: fix disable sequence
  2017-07-12 10:01 ` [PATCH] drm/exynos/hdmi: fix disable sequence Andrzej Hajda
@ 2017-07-12 10:31   ` Marek Szyprowski
  0 siblings, 0 replies; 2+ messages in thread
From: Marek Szyprowski @ 2017-07-12 10:31 UTC (permalink / raw)
  To: Andrzej Hajda, Inki Dae
  Cc: Bartlomiej Zolnierkiewicz, dri-devel, linux-samsung-soc

Hi

On 2017-07-12 12:01, Andrzej Hajda wrote:
> The "Fixes" patch was incorrectly merged, as a result PHY is prematurely
> powered off and for example Odroid-U3 cannot disable TV power domain
> when HDMI cable is unplugged.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Fixes: 625e63e2 ("drm/exynos/hdmi: fix pipeline disable order")~

This patch finally fixes the 'Power domain TV disable failed' issue in 
linux-next.

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---
>   drivers/gpu/drm/exynos/exynos_hdmi.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index e65cdbf..b1718d8 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -1501,8 +1501,6 @@ static void hdmi_disable(struct drm_encoder *encoder)
>   	 */
>   	cancel_delayed_work(&hdata->hotplug_work);
>   	cec_notifier_set_phys_addr(hdata->notifier, CEC_PHYS_ADDR_INVALID);
> -
> -	hdmiphy_disable(hdata);
>   }
>   
>   static const struct drm_encoder_helper_funcs exynos_hdmi_encoder_helper_funcs = {

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-07-12 10:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20170712100130eucas1p28e5dd505bee3f5e7f09d81bab8e5ba06@eucas1p2.samsung.com>
2017-07-12 10:01 ` [PATCH] drm/exynos/hdmi: fix disable sequence Andrzej Hajda
2017-07-12 10:31   ` Marek Szyprowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox