dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] drm: fix fallout from drm_print.h include cleanups
@ 2025-11-03  9:22 Jani Nikula
  2025-11-03  9:22 ` [PATCH 1/2] drm/renesas: include drm_print.h where needed Jani Nikula
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Jani Nikula @ 2025-11-03  9:22 UTC (permalink / raw)
  To: dri-devel, Thomas Zimmermann, Stephen Rothwell; +Cc: jani.nikula

Fix some (I guess inevitable) fallout from the drm_print.h cleanups.

Note: I'm setting Fixes: f6e8dc9edf96 ("drm: include drm_print.h where
needed") instead of the ones removing drm_print.h includes, because that
was the one that was supposed to have them all.

Jani Nikula (2):
  drm/renesas: include drm_print.h where needed
  drm/rockchip: include drm_print.h where needed

 drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 1 +
 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 +
 2 files changed, 2 insertions(+)

-- 
2.47.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] drm/renesas: include drm_print.h where needed
  2025-11-03  9:22 [PATCH 0/2] drm: fix fallout from drm_print.h include cleanups Jani Nikula
@ 2025-11-03  9:22 ` Jani Nikula
  2025-11-03  9:22 ` [PATCH 2/2] drm/rockchip: " Jani Nikula
  2025-11-03  9:29 ` [PATCH 0/2] drm: fix fallout from drm_print.h include cleanups Thomas Zimmermann
  2 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2025-11-03  9:22 UTC (permalink / raw)
  To: dri-devel, Thomas Zimmermann, Stephen Rothwell; +Cc: jani.nikula

rzg2l_du_drv.c depends on drm_print.h being indirectly included via
drm_buddy.h, drm_mm.h, or ttm/ttm_resource.h. Include drm_print.h
explicitly.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/r/20251103112418.031b3f8c@canb.auug.org.au
Fixes: f6e8dc9edf96 ("drm: include drm_print.h where needed")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
index e1aa6a719529..0fef33a5a089 100644
--- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
+++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
@@ -17,6 +17,7 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_fbdev_dma.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 
 #include "rzg2l_du_drv.h"
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] drm/rockchip: include drm_print.h where needed
  2025-11-03  9:22 [PATCH 0/2] drm: fix fallout from drm_print.h include cleanups Jani Nikula
  2025-11-03  9:22 ` [PATCH 1/2] drm/renesas: include drm_print.h where needed Jani Nikula
@ 2025-11-03  9:22 ` Jani Nikula
  2025-11-03  9:29 ` [PATCH 0/2] drm: fix fallout from drm_print.h include cleanups Thomas Zimmermann
  2 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2025-11-03  9:22 UTC (permalink / raw)
  To: dri-devel, Thomas Zimmermann, Stephen Rothwell; +Cc: jani.nikula

rockchip_drm_vop2.c depends on drm_print.h being indirectly included via
drm_buddy.h, drm_mm.h, or ttm/ttm_resource.h. Include drm_print.h
explicitly.

Reported-by: Thomas Zimmermann <tzimmermann@suse.de>
Closes: https://lore.kernel.org/r/9c67c29b-06e9-469b-9273-eaac368632d6@suse.de
Fixes: f6e8dc9edf96 ("drm: include drm_print.h where needed")
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 284c8a048034..e979d5e02ff4 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -29,6 +29,7 @@
 #include <drm/drm_flip_work.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] drm: fix fallout from drm_print.h include cleanups
  2025-11-03  9:22 [PATCH 0/2] drm: fix fallout from drm_print.h include cleanups Jani Nikula
  2025-11-03  9:22 ` [PATCH 1/2] drm/renesas: include drm_print.h where needed Jani Nikula
  2025-11-03  9:22 ` [PATCH 2/2] drm/rockchip: " Jani Nikula
@ 2025-11-03  9:29 ` Thomas Zimmermann
  2025-11-03 14:04   ` Jani Nikula
  2 siblings, 1 reply; 5+ messages in thread
From: Thomas Zimmermann @ 2025-11-03  9:29 UTC (permalink / raw)
  To: Jani Nikula, dri-devel, Stephen Rothwell



Am 03.11.25 um 10:22 schrieb Jani Nikula:
> Fix some (I guess inevitable) fallout from the drm_print.h cleanups.
>
> Note: I'm setting Fixes: f6e8dc9edf96 ("drm: include drm_print.h where
> needed") instead of the ones removing drm_print.h includes, because that
> was the one that was supposed to have them all.
>
> Jani Nikula (2):
>    drm/renesas: include drm_print.h where needed
>    drm/rockchip: include drm_print.h where needed

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

for the series.

>
>   drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 1 +
>   drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 +
>   2 files changed, 2 insertions(+)
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] drm: fix fallout from drm_print.h include cleanups
  2025-11-03  9:29 ` [PATCH 0/2] drm: fix fallout from drm_print.h include cleanups Thomas Zimmermann
@ 2025-11-03 14:04   ` Jani Nikula
  0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2025-11-03 14:04 UTC (permalink / raw)
  To: Thomas Zimmermann, dri-devel, Stephen Rothwell

On Mon, 03 Nov 2025, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Am 03.11.25 um 10:22 schrieb Jani Nikula:
>> Fix some (I guess inevitable) fallout from the drm_print.h cleanups.
>>
>> Note: I'm setting Fixes: f6e8dc9edf96 ("drm: include drm_print.h where
>> needed") instead of the ones removing drm_print.h includes, because that
>> was the one that was supposed to have them all.
>>
>> Jani Nikula (2):
>>    drm/renesas: include drm_print.h where needed
>>    drm/rockchip: include drm_print.h where needed
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> for the series.

Thanks, pushed to drm-misc-next.

BR,
Jani.

>
>>
>>   drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 1 +
>>   drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 +
>>   2 files changed, 2 insertions(+)
>>

-- 
Jani Nikula, Intel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-11-03 14:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-03  9:22 [PATCH 0/2] drm: fix fallout from drm_print.h include cleanups Jani Nikula
2025-11-03  9:22 ` [PATCH 1/2] drm/renesas: include drm_print.h where needed Jani Nikula
2025-11-03  9:22 ` [PATCH 2/2] drm/rockchip: " Jani Nikula
2025-11-03  9:29 ` [PATCH 0/2] drm: fix fallout from drm_print.h include cleanups Thomas Zimmermann
2025-11-03 14:04   ` Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox