* ww-mutex performance tests?
@ 2018-04-02 17:49 Thomas Hellstrom
2018-04-03 8:37 ` Maarten Lankhorst
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Hellstrom @ 2018-04-02 17:49 UTC (permalink / raw)
To: Daniel Vetter, Maarten Lankhorst; +Cc: dri-devel@lists.freedesktop.org
Maarten, Daniel,
Do we have any ww-mutex performance tests somewhere that can be used to
test the impact of implementation details on various locking scenarios?
Thanks,
/Thomas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ww-mutex performance tests?
2018-04-02 17:49 ww-mutex performance tests? Thomas Hellstrom
@ 2018-04-03 8:37 ` Maarten Lankhorst
2018-04-04 17:12 ` Thomas Hellstrom
2018-04-04 18:02 ` Daniel Vetter
0 siblings, 2 replies; 5+ messages in thread
From: Maarten Lankhorst @ 2018-04-03 8:37 UTC (permalink / raw)
To: Thomas Hellstrom, Daniel Vetter; +Cc: dri-devel@lists.freedesktop.org
Op 02-04-18 om 19:49 schreef Thomas Hellstrom:
> Maarten, Daniel,
>
> Do we have any ww-mutex performance tests somewhere that can be used to test the impact of implementation details on various locking scenarios?
>
> Thanks,
>
> /Thomas
>
>
The thing that comes to my mind are some of the kms_cursor_legacy tests that have been proven to be sensitive to locking issues before.
All subtests with (pipe-*/all-pipes)-(single/forked/torture)-(bo/move) try to do cursor updates as fast as possible, and report how many updates have been done.
~Maarten
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ww-mutex performance tests?
2018-04-03 8:37 ` Maarten Lankhorst
@ 2018-04-04 17:12 ` Thomas Hellstrom
2018-04-04 18:02 ` Daniel Vetter
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Hellstrom @ 2018-04-04 17:12 UTC (permalink / raw)
To: Maarten Lankhorst, Daniel Vetter; +Cc: dri-devel@lists.freedesktop.org
On 04/03/2018 10:37 AM, Maarten Lankhorst wrote:
> Op 02-04-18 om 19:49 schreef Thomas Hellstrom:
>> Maarten, Daniel,
>>
>> Do we have any ww-mutex performance tests somewhere that can be used to test the impact of implementation details on various locking scenarios?
>>
>> Thanks,
>>
>> /Thomas
>>
>>
> The thing that comes to my mind are some of the kms_cursor_legacy tests that have been proven to be sensitive to locking issues before.
> All subtests with (pipe-*/all-pipes)-(single/forked/torture)-(bo/move) try to do cursor updates as fast as possible, and report how many updates have been done.
>
> ~Maarten
>
Thanks, Maarten.
/Thomas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ww-mutex performance tests?
2018-04-03 8:37 ` Maarten Lankhorst
2018-04-04 17:12 ` Thomas Hellstrom
@ 2018-04-04 18:02 ` Daniel Vetter
2018-04-05 6:41 ` Christian König
1 sibling, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2018-04-04 18:02 UTC (permalink / raw)
To: Maarten Lankhorst, Christian König, Alex Deucher
Cc: Thomas Hellstrom, dri-devel@lists.freedesktop.org
On Tue, Apr 3, 2018 at 10:37 AM, Maarten Lankhorst
<maarten.lankhorst@linux.intel.com> wrote:
> Op 02-04-18 om 19:49 schreef Thomas Hellstrom:
>> Maarten, Daniel,
>>
>> Do we have any ww-mutex performance tests somewhere that can be used to test the impact of implementation details on various locking scenarios?
>>
>> Thanks,
>>
>> /Thomas
>>
>>
> The thing that comes to my mind are some of the kms_cursor_legacy tests that have been proven to be sensitive to locking issues before.
> All subtests with (pipe-*/all-pipes)-(single/forked/torture)-(bo/move) try to do cursor updates as fast as possible, and report how many updates have been done.
AMD folks have a bunch of tests to exercise their CS paths I think,
that should be interesting for the multi-ww_mutex/backoff paths,
adding Christian et al.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ww-mutex performance tests?
2018-04-04 18:02 ` Daniel Vetter
@ 2018-04-05 6:41 ` Christian König
0 siblings, 0 replies; 5+ messages in thread
From: Christian König @ 2018-04-05 6:41 UTC (permalink / raw)
To: Daniel Vetter, Maarten Lankhorst, Alex Deucher
Cc: Thomas Hellstrom, dri-devel@lists.freedesktop.org
Am 04.04.2018 um 20:02 schrieb Daniel Vetter:
> On Tue, Apr 3, 2018 at 10:37 AM, Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com> wrote:
>> Op 02-04-18 om 19:49 schreef Thomas Hellstrom:
>>> Maarten, Daniel,
>>>
>>> Do we have any ww-mutex performance tests somewhere that can be used to test the impact of implementation details on various locking scenarios?
>>>
>>> Thanks,
>>>
>>> /Thomas
>>>
>>>
>> The thing that comes to my mind are some of the kms_cursor_legacy tests that have been proven to be sensitive to locking issues before.
>> All subtests with (pipe-*/all-pipes)-(single/forked/torture)-(bo/move) try to do cursor updates as fast as possible, and report how many updates have been done.
> AMD folks have a bunch of tests to exercise their CS paths I think,
> that should be interesting for the multi-ww_mutex/backoff paths,
> adding Christian et al.
Well not a dedicated test for this, but at least I usually run glmark
with thread offloading disabled to measure the command submission overhead.
Except for the usual stuff like copying things from userspace the last
time I looked our command submission overhead was dominated by work done
for individual BOs.
Not sure how much of that accounts for locking the ww_mutex of the BOs,
but I would guess it is quite a bit.
Christian.
> -Daniel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-05 6:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-02 17:49 ww-mutex performance tests? Thomas Hellstrom
2018-04-03 8:37 ` Maarten Lankhorst
2018-04-04 17:12 ` Thomas Hellstrom
2018-04-04 18:02 ` Daniel Vetter
2018-04-05 6:41 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox