From: Thomas Zimmermann <tzimmermann@suse.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Sam Bobroff <sbobroff@linux.ibm.com>,
YueHaibing <yuehaibing@huawei.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Dave Airlie <airlied@redhat.com>,
Alex Deucher <alexander.deucher@amd.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 2/2] drm/ast: Drop fb_debug_enter/leave
Date: Thu, 13 Jun 2019 08:45:49 +0200 [thread overview]
Message-ID: <d5fc5fa6-ae80-e82d-e0f7-94b9559e5af9@suse.de> (raw)
In-Reply-To: <20190612091253.26413-2-daniel.vetter@ffwll.ch>
[-- Attachment #1.1.1: Type: text/plain, Size: 1442 bytes --]
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Am 12.06.19 um 11:12 schrieb Daniel Vetter:
> ast doesn't implement the mode_set_base_atomic hook this would need,
> so this is dead code.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Sam Bobroff <sbobroff@linux.ibm.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/ast/ast_fb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> index 05f45222b702..5480caecde86 100644
> --- a/drivers/gpu/drm/ast/ast_fb.c
> +++ b/drivers/gpu/drm/ast/ast_fb.c
> @@ -166,8 +166,6 @@ static struct fb_ops astfb_ops = {
> .fb_pan_display = drm_fb_helper_pan_display,
> .fb_blank = drm_fb_helper_blank,
> .fb_setcmap = drm_fb_helper_setcmap,
> - .fb_debug_enter = drm_fb_helper_debug_enter,
> - .fb_debug_leave = drm_fb_helper_debug_leave,
> };
>
> static int astfb_create_object(struct ast_fbdev *afbdev,
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-13 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 9:12 [PATCH 1/2] drm/omapdrm: drop fb_debug_enter/leave Daniel Vetter
2019-06-12 9:12 ` [PATCH 2/2] drm/ast: Drop fb_debug_enter/leave Daniel Vetter
2019-06-13 6:45 ` Thomas Zimmermann [this message]
2019-06-13 8:19 ` Daniel Vetter
2019-06-12 9:19 ` [PATCH 1/2] drm/omapdrm: drop fb_debug_enter/leave Tomi Valkeinen
2019-06-12 12:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5fc5fa6-ae80-e82d-e0f7-94b9559e5af9@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=sam@ravnborg.org \
--cc=sbobroff@linux.ibm.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox