From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
Jyri Sarha <jsarha@ti.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCHv2 17/17] drm/omap: cleanup color space conversion
Date: Thu, 1 Mar 2018 09:02:25 +0200 [thread overview]
Message-ID: <db4e601d-ac8c-90df-5191-329d34de8422@ti.com> (raw)
In-Reply-To: <1783934.fCbxS1ssXs@avalon>
On 28/02/18 23:23, Laurent Pinchart wrote:
>> + REG_FLD_MOD(dispc, DISPC_OVL_ATTRIBUTES(plane), !!ct->full_range, 11, 11);
>
> I think I mentioned in my review of v1 that you can drop the !!. Apart from
> that,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Sorry about. I did remove it, but I made a few versions of the change,
and apparently missed this in the final one. Now it's gone.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-03-01 7:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 11:25 [PATCHv2 00/17] drm/omap: misc patches Tomi Valkeinen
2018-02-28 11:25 ` [PATCHv2 01/17] drm/omap: fix omap_fbdev_free() when omap_fbdev_create() wasn't called Tomi Valkeinen
2018-06-10 12:22 ` Sebastian Reichel
2018-02-28 11:25 ` [PATCHv2 02/17] drm/omap: cleanup fbdev init/free Tomi Valkeinen
2018-02-28 21:18 ` Laurent Pinchart
2018-06-10 13:18 ` Sebastian Reichel
2018-02-28 11:26 ` [PATCHv2 03/17] drm/omap: Init fbdev emulation only when we have displays Tomi Valkeinen
2018-06-10 13:19 ` Sebastian Reichel
2018-02-28 11:26 ` [PATCHv2 04/17] drm/omap: add HPD support to connector-dvi Tomi Valkeinen
2018-02-28 21:19 ` Laurent Pinchart
2018-06-10 13:53 ` Sebastian Reichel
2018-02-28 11:26 ` [PATCHv2 05/17] dt-bindings: display: add HPD gpio to DVI connector Tomi Valkeinen
2018-06-10 13:54 ` Sebastian Reichel
2018-02-28 11:26 ` [PATCHv2 06/17] drm/omap: remove leftover enums Tomi Valkeinen
2018-06-10 13:57 ` Sebastian Reichel
2018-02-28 11:26 ` [PATCHv2 07/17] drm/omap: dispc: disp_wb_setup to check return code Tomi Valkeinen
2018-06-10 14:03 ` Sebastian Reichel
2018-02-28 11:26 ` [PATCHv2 08/17] drm/omap: Add pclk setting case when channel is DSS_WB Tomi Valkeinen
2018-02-28 11:26 ` [PATCHv2 09/17] drm/omap: set WB channel-in in wb_setup() Tomi Valkeinen
2018-02-28 11:26 ` [PATCHv2 10/17] drm/omap: fix WBDELAYCOUNT for HDMI Tomi Valkeinen
2018-02-28 11:26 ` [PATCHv2 11/17] drm/omap: fix WBDELAYCOUNT with interlace Tomi Valkeinen
2018-02-28 11:26 ` [PATCHv2 12/17] drm/omap: fix WB height " Tomi Valkeinen
2018-02-28 11:26 ` [PATCHv2 13/17] drm/omap: fix scaling limits for WB Tomi Valkeinen
2018-02-28 11:26 ` [PATCHv2 14/17] drm/omap: add writeback funcs to dispc_ops Tomi Valkeinen
2018-02-28 11:26 ` [PATCHv2 15/17] drm/omap: fix maximum sizes Tomi Valkeinen
2018-02-28 11:26 ` [PATCHv2 16/17] drm/omap: Allow HDMI audio setup even if we do not have video configured Tomi Valkeinen
2018-02-28 11:26 ` [PATCHv2 17/17] drm/omap: cleanup color space conversion Tomi Valkeinen
2018-02-28 21:23 ` Laurent Pinchart
2018-03-01 7:02 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db4e601d-ac8c-90df-5191-329d34de8422@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox