dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
	Intel-gfx@lists.freedesktop.org,
	Tejas Upadhyay <tejas.upadhyay@intel.com>,
	dri-devel@lists.freedesktop.org,
	Aravind Iddamsetty <aravind.iddamsetty@intel.com>
Subject: Re: [PATCH 6/6] drm/i915: Implement fdinfo memory stats printing
Date: Wed, 27 Sep 2023 14:23:19 +0100	[thread overview]
Message-ID: <e71f48e4-b2a9-3e73-23d8-a7fddef19ab8@linux.intel.com> (raw)
In-Reply-To: <ZRPRmaSyZlKnK+xl@ashyti-mobl2.lan>


On 27/09/2023 07:54, Andi Shyti wrote:
> Hi Tvrtko,
> 
>> Use the newly added drm_print_memory_stats helper to show memory
>> utilisation of our objects in drm/driver specific fdinfo output.
>>
>> To collect the stats we walk the per memory regions object lists
>> and accumulate object size into the respective drm_memory_stats
>> categories.
>>
>> v2:
>>   * Only account against the active region.
>>   * Use DMA_RESV_USAGE_BOOKKEEP when testing for active. (Tejas)
>>
>> v3:
>>   * Update commit text. (Aravind)
>>   * Update to use memory regions uabi names.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
>> Cc: Rob Clark <robdclark@gmail.com>
>> Cc: Andi Shyti <andi.shyti@linux.intel.com>
>> Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
>> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> # v1
>> Reviewed-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com> # v2
> 
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks guys, just the IGTs remaining now. I've just sent a respin of one 
patch in that series which will hopefully fix things up.

* https://patchwork.freedesktop.org/series/124118/

First two patches is what we need to merge the kernel side, while the 
rest are intel_gpu_top fixes followed by per client memory support.

Regards,

Tvrtko


  reply	other threads:[~2023-09-27 13:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22 13:46 [PATCH v7 0/6] fdinfo memory stats Tvrtko Ursulin
2023-09-22 13:46 ` [PATCH 1/6] drm/i915: Add ability for tracking buffer objects per client Tvrtko Ursulin
2023-09-22 13:46 ` [PATCH 2/6] drm/i915: Record which client owns a VM Tvrtko Ursulin
2023-09-22 13:46 ` [PATCH 3/6] drm/i915: Track page table backing store usage Tvrtko Ursulin
2023-09-22 13:46 ` [PATCH 4/6] drm/i915: Account ring buffer and context state storage Tvrtko Ursulin
2023-09-22 13:46 ` [PATCH 5/6] drm/i915: Add stable memory region names Tvrtko Ursulin
2023-09-26 15:29   ` Iddamsetty, Aravind
2023-09-26 15:42     ` Tvrtko Ursulin
2023-09-27  4:43       ` Iddamsetty, Aravind
2023-09-22 13:47 ` [PATCH 6/6] drm/i915: Implement fdinfo memory stats printing Tvrtko Ursulin
2023-09-27  4:58   ` Iddamsetty, Aravind
2023-09-27  6:54   ` Andi Shyti
2023-09-27 13:23     ` Tvrtko Ursulin [this message]
2023-09-27 13:24       ` Tvrtko Ursulin
2023-09-27  8:07   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e71f48e4-b2a9-3e73-23d8-a7fddef19ab8@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=andi.shyti@linux.intel.com \
    --cc=aravind.iddamsetty@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=tejas.upadhyay@intel.com \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox