Re: [PATCH 6/6] drm/i915: Implement fdinfo memory stats printing

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 27/09/2023 14:23, Tvrtko Ursulin wrote:
> 
> On 27/09/2023 07:54, Andi Shyti wrote:
>> Hi Tvrtko,
>>
>>> Use the newly added drm_print_memory_stats helper to show memory
>>> utilisation of our objects in drm/driver specific fdinfo output.
>>>
>>> To collect the stats we walk the per memory regions object lists
>>> and accumulate object size into the respective drm_memory_stats
>>> categories.
>>>
>>> v2:
>>>   * Only account against the active region.
>>>   * Use DMA_RESV_USAGE_BOOKKEEP when testing for active. (Tejas)
>>>
>>> v3:
>>>   * Update commit text. (Aravind)
>>>   * Update to use memory regions uabi names.
>>>
>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>> Cc: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
>>> Cc: Rob Clark <robdclark@gmail.com>
>>> Cc: Andi Shyti <andi.shyti@linux.intel.com>
>>> Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
>>> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> # v1
>>> Reviewed-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com> # v2
>>
>> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> 
> Thanks guys, just the IGTs remaining now. I've just sent a respin of one 
> patch in that series which will hopefully fix things up.

Actually no, I forgot that decided I will respin the i915 series with 
yet one more patch. Stay tuned please.

Regards,

Tvrtko

> * https://patchwork.freedesktop.org/series/124118/
> 
> First two patches is what we need to merge the kernel side, while the 
> rest are intel_gpu_top fixes followed by per client memory support.
> 
> Regards,
> 
> Tvrtko
>