From: Christopher Harvey <charvey@matrox.com>
To: dri-devel@lists.freedesktop.org
Cc: Mathieu Larouche <mathieu.larouche@matrox.com>
Subject: [PATCH v2 3/4] drm/mgag200: Convert counter delays to jiffies
Date: Mon, 6 May 2013 11:56:17 -0400 [thread overview]
Message-ID: <efbc2aeff295fb006c35b6bf643578043d53fb0b.1368128053.git.charvey@matrox.com> (raw)
In-Reply-To: <cover.1368128053.git.charvey@matrox.com>
Signed-off-by: Christopher Harvey <charvey@matrox.com>
Acked-by: Julia Lemire <jlemire@matrox.com>
Tested-by: Julia Lemire <jlemire@matrox.com>
Acked-by: Mathieu Larouche <mathieu.larouche@matrox.com>
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 6f3b9db..6dbf6de 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -46,29 +46,26 @@ static void mga_crtc_load_lut(struct drm_crtc *crtc)
static inline void mga_wait_vsync(struct mga_device *mdev)
{
- unsigned int count = 0;
+ unsigned long timeout = jiffies + HZ/10;
unsigned int status = 0;
do {
status = RREG32(MGAREG_Status);
- count++;
- } while ((status & 0x08) && (count < 250000));
- count = 0;
+ } while ((status & 0x08) && time_before(jiffies, timeout));
+ timeout = jiffies + HZ/10;
status = 0;
do {
status = RREG32(MGAREG_Status);
- count++;
- } while (!(status & 0x08) && (count < 250000));
+ } while (!(status & 0x08) && time_before(jiffies, timeout));
}
static inline void mga_wait_busy(struct mga_device *mdev)
{
- unsigned int count = 0;
+ unsigned long timeout = jiffies + HZ;
unsigned int status = 0;
do {
status = RREG8(MGAREG_Status + 2);
- count++;
- } while ((status & 0x01) && (count < 500000));
+ } while ((status & 0x01) && time_before(jiffies, timeout));
}
/*
--
1.8.1.5
next prev parent reply other threads:[~2013-05-09 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 19:34 [PATCH v2 0/4] *** SUBJECT HERE *** Christopher Harvey
2013-04-12 20:42 ` [PATCH v2 1/4] drm/mgag200: Don't change unrelated registers during modeset Christopher Harvey
2013-04-12 22:24 ` [PATCH v2 2/4] drm/mgag200: Fix writes into MGA1064_PIX_CLK_CTL register Christopher Harvey
2013-05-06 15:56 ` Christopher Harvey [this message]
2013-05-08 19:10 ` [PATCH v2 4/4] drm/mgag200: Fix framebuffer base address programming Christopher Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efbc2aeff295fb006c35b6bf643578043d53fb0b.1368128053.git.charvey@matrox.com \
--to=charvey@matrox.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=mathieu.larouche@matrox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox