From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/omap: displays: panel-dpi: add backlight dependency
Date: Thu, 12 Oct 2017 11:05:45 +0300 [thread overview]
Message-ID: <f893de86-a16a-964f-a998-e574f75bf3d4@ti.com> (raw)
In-Reply-To: <20171005120651.376485-1-arnd@arndb.de>
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 05/10/17 15:06, Arnd Bergmann wrote:
> The new backlight code causes a link failure when backlight
> support itself is disabled:
>
> drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function `panel_dpi_probe_of':
> panel-dpi.c:(.text+0x35c): undefined reference to `of_find_backlight_by_node'
>
> This adds a Kconfig dependency like we have for the other OMAP
> display targets.
>
> Fixes: 39135a305a0f ("drm/omap: displays: panel-dpi: Support for handling backlight devices")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/omapdrm/displays/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/displays/Kconfig b/drivers/gpu/drm/omapdrm/displays/Kconfig
> index c226da145fb3..a349cb61961e 100644
> --- a/drivers/gpu/drm/omapdrm/displays/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/displays/Kconfig
> @@ -35,6 +35,7 @@ config DRM_OMAP_CONNECTOR_ANALOG_TV
>
> config DRM_OMAP_PANEL_DPI
> tristate "Generic DPI panel"
> + depends on BACKLIGHT_CLASS_DEVICE
> help
> Driver for generic DPI panels.
Thanks, I've queued this for 4.14 fixes.
Tomi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-10-12 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 12:06 [PATCH] drm/omap: displays: panel-dpi: add backlight dependency Arnd Bergmann
2017-10-12 8:05 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f893de86-a16a-964f-a998-e574f75bf3d4@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox