dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/omap: displays: panel-dpi: add backlight dependency
@ 2017-10-05 12:06 Arnd Bergmann
  2017-10-12  8:05 ` Tomi Valkeinen
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-10-05 12:06 UTC (permalink / raw)
  To: Tomi Valkeinen, David Airlie; +Cc: Arnd Bergmann, dri-devel, linux-kernel

The new backlight code causes a link failure when backlight
support itself is disabled:

drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function `panel_dpi_probe_of':
panel-dpi.c:(.text+0x35c): undefined reference to `of_find_backlight_by_node'

This adds a Kconfig dependency like we have for the other OMAP
display targets.

Fixes: 39135a305a0f ("drm/omap: displays: panel-dpi: Support for handling backlight devices")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/omapdrm/displays/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/omapdrm/displays/Kconfig b/drivers/gpu/drm/omapdrm/displays/Kconfig
index c226da145fb3..a349cb61961e 100644
--- a/drivers/gpu/drm/omapdrm/displays/Kconfig
+++ b/drivers/gpu/drm/omapdrm/displays/Kconfig
@@ -35,6 +35,7 @@ config DRM_OMAP_CONNECTOR_ANALOG_TV
 
 config DRM_OMAP_PANEL_DPI
 	tristate "Generic DPI panel"
+	depends on BACKLIGHT_CLASS_DEVICE
 	help
 	  Driver for generic DPI panels.
 
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/omap: displays: panel-dpi: add backlight dependency
  2017-10-05 12:06 [PATCH] drm/omap: displays: panel-dpi: add backlight dependency Arnd Bergmann
@ 2017-10-12  8:05 ` Tomi Valkeinen
  0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2017-10-12  8:05 UTC (permalink / raw)
  To: Arnd Bergmann, David Airlie; +Cc: linux-kernel, dri-devel


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 05/10/17 15:06, Arnd Bergmann wrote:
> The new backlight code causes a link failure when backlight
> support itself is disabled:
> 
> drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function `panel_dpi_probe_of':
> panel-dpi.c:(.text+0x35c): undefined reference to `of_find_backlight_by_node'
> 
> This adds a Kconfig dependency like we have for the other OMAP
> display targets.
> 
> Fixes: 39135a305a0f ("drm/omap: displays: panel-dpi: Support for handling backlight devices")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/omapdrm/displays/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/Kconfig b/drivers/gpu/drm/omapdrm/displays/Kconfig
> index c226da145fb3..a349cb61961e 100644
> --- a/drivers/gpu/drm/omapdrm/displays/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/displays/Kconfig
> @@ -35,6 +35,7 @@ config DRM_OMAP_CONNECTOR_ANALOG_TV
>  
>  config DRM_OMAP_PANEL_DPI
>  	tristate "Generic DPI panel"
> +	depends on BACKLIGHT_CLASS_DEVICE
>  	help
>  	  Driver for generic DPI panels.

Thanks, I've queued this for 4.14 fixes.

 Tomi

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-10-12  8:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-05 12:06 [PATCH] drm/omap: displays: panel-dpi: add backlight dependency Arnd Bergmann
2017-10-12  8:05 ` Tomi Valkeinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox