* [PATCH] drm/i915: free _DSM package when no connectors
@ 2026-01-09 3:25 Kaushlendra Kumar
2026-01-09 8:57 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Kaushlendra Kumar @ 2026-01-09 3:25 UTC (permalink / raw)
To: jani.nikula, rodrigo.vivi, joonas.lahtinen, tursulin, airlied,
simona
Cc: intel-gfx, intel-xe, dri-devel, Kaushlendra Kumar
acpi_evaluate_dsm_typed() returns an ACPI package in pkg.
When pkg->package.count == 0, we returned without freeing pkg,
leaking memory. Free pkg before returning on the empty case.
Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
---
drivers/gpu/drm/i915/display/intel_acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
index 68c01932f7b4..e06f324027be 100644
--- a/drivers/gpu/drm/i915/display/intel_acpi.c
+++ b/drivers/gpu/drm/i915/display/intel_acpi.c
@@ -96,6 +96,7 @@ static void intel_dsm_platform_mux_info(acpi_handle dhandle)
if (!pkg->package.count) {
DRM_DEBUG_DRIVER("no connection in _DSM\n");
+ ACPI_FREE(pkg);
return;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: free _DSM package when no connectors
2026-01-09 3:25 [PATCH] drm/i915: free _DSM package when no connectors Kaushlendra Kumar
@ 2026-01-09 8:57 ` Jani Nikula
2026-02-11 12:03 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2026-01-09 8:57 UTC (permalink / raw)
To: Kaushlendra Kumar, rodrigo.vivi, joonas.lahtinen, tursulin,
airlied, simona
Cc: intel-gfx, intel-xe, dri-devel, Kaushlendra Kumar
Subject prefix "drm/i915/acpi:"
On Fri, 09 Jan 2026, Kaushlendra Kumar <kaushlendra.kumar@intel.com> wrote:
> acpi_evaluate_dsm_typed() returns an ACPI package in pkg.
> When pkg->package.count == 0, we returned without freeing pkg,
> leaking memory. Free pkg before returning on the empty case.
Fixes: 337d7a1621c7 ("drm/i915: Fix invalid access to ACPI _DSM objects")
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: <stable@vger.kernel.org> # v5.14+
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_acpi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
> index 68c01932f7b4..e06f324027be 100644
> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> @@ -96,6 +96,7 @@ static void intel_dsm_platform_mux_info(acpi_handle dhandle)
>
> if (!pkg->package.count) {
> DRM_DEBUG_DRIVER("no connection in _DSM\n");
> + ACPI_FREE(pkg);
> return;
> }
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: free _DSM package when no connectors
2026-01-09 8:57 ` Jani Nikula
@ 2026-02-11 12:03 ` Jani Nikula
0 siblings, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2026-02-11 12:03 UTC (permalink / raw)
To: Kaushlendra Kumar, rodrigo.vivi, joonas.lahtinen, tursulin,
airlied, simona
Cc: intel-gfx, intel-xe, dri-devel, Kaushlendra Kumar
On Fri, 09 Jan 2026, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> Subject prefix "drm/i915/acpi:"
>
> On Fri, 09 Jan 2026, Kaushlendra Kumar <kaushlendra.kumar@intel.com> wrote:
>> acpi_evaluate_dsm_typed() returns an ACPI package in pkg.
>> When pkg->package.count == 0, we returned without freeing pkg,
>> leaking memory. Free pkg before returning on the empty case.
>
> Fixes: 337d7a1621c7 ("drm/i915: Fix invalid access to ACPI _DSM objects")
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v5.14+
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Pushed to drm-intel-next, thanks for the patch.
BR,
Jani.
>
>> Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_acpi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
>> index 68c01932f7b4..e06f324027be 100644
>> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
>> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
>> @@ -96,6 +96,7 @@ static void intel_dsm_platform_mux_info(acpi_handle dhandle)
>>
>> if (!pkg->package.count) {
>> DRM_DEBUG_DRIVER("no connection in _DSM\n");
>> + ACPI_FREE(pkg);
>> return;
>> }
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-11 12:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-09 3:25 [PATCH] drm/i915: free _DSM package when no connectors Kaushlendra Kumar
2026-01-09 8:57 ` Jani Nikula
2026-02-11 12:03 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox