From: Keith Packard <keithp@keithp.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>, dri-devel@lists.freedesktop.org
Subject: Re: Unchecked memory allocations in Intel driver
Date: Mon, 04 Jul 2011 11:18:13 -0700 [thread overview]
Message-ID: <yunsjqlsye2.fsf@aiko.keithp.com> (raw)
In-Reply-To: <20110704132751.4eaf5489@lxorguk.ukuu.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 421 bytes --]
On Mon, 4 Jul 2011 13:27:51 +0100, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> Found this going over intel_bios.c and cross comparing it with the
> Intel/IMG driver intel_bios.c
>
> temp_mode = kzalloc(sizeof(*temp_mode), GFP_KERNEL);
This object is about 216 bytes long; would it be reasonable to allocate
it on the stack? Or is that pushing stack allocations too far?
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2011-07-04 18:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 12:27 Unchecked memory allocations in Intel driver Alan Cox
2011-07-04 18:18 ` Keith Packard [this message]
2011-07-04 19:55 ` Alan Cox
2011-07-05 8:55 ` [PATCH] drm/i915/bios: Avoid temporary allocation whilst searching for downclock Chris Wilson
2011-07-13 18:13 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunsjqlsye2.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox