From: Keith Packard <keithp@keithp.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bios: Avoid temporary allocation whilst searching for downclock
Date: Wed, 13 Jul 2011 11:13:24 -0700 [thread overview]
Message-ID: <yunhb6q9hh7.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1309856134-20486-1-git-send-email-chris@chris-wilson.co.uk>
[-- Attachment #1.1: Type: text/plain, Size: 736 bytes --]
On Tue, 5 Jul 2011 09:55:34 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Alan Cox reported a missing check on the kmalloc return value for the
> allocation of a temporary mode used for searching for the LVDS downlock
> frequency. This allocation is roughly 200 bytes, a little too large to
> friviously place on the stack. However, we can simply use the few bytes
> we need stored within the original DVO timing data, skip the translation
> and do the compare directly between the timing data rather than on a
> mode, thus avoiding the need for any temporary allocations.
Can you clean this one up for -next? I'm merging bug fixes to -next to
send off for post-3.0 integration.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2011-07-13 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 12:27 Unchecked memory allocations in Intel driver Alan Cox
2011-07-04 18:18 ` Keith Packard
2011-07-04 19:55 ` Alan Cox
2011-07-05 8:55 ` [PATCH] drm/i915/bios: Avoid temporary allocation whilst searching for downclock Chris Wilson
2011-07-13 18:13 ` Keith Packard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunhb6q9hh7.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox