* [PATCH] isa: refactor code to remove nested blocks
@ 2026-06-24 12:20 Syed Nayyar Waris
2026-06-26 11:13 ` William Breathitt Gray
0 siblings, 1 reply; 2+ messages in thread
From: Syed Nayyar Waris @ 2026-06-24 12:20 UTC (permalink / raw)
To: wbg; +Cc: gregkh, rafael, dakr, driver-core, linux-kernel, syednwaris
Remove nested blocks in isa_bus_init()
Suggested-by: William Breathitt Gray <wbg@kernel.org>
Signed-off-by: Syed Nayyar Waris <syednwaris@gmail.com>
---
drivers/base/isa.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/base/isa.c b/drivers/base/isa.c
index 5887e4211f80..4e9f68080f39 100644
--- a/drivers/base/isa.c
+++ b/drivers/base/isa.c
@@ -166,14 +166,16 @@ static int __init isa_bus_init(void)
int error;
error = bus_register(&isa_bus_type);
- if (!error) {
- isa_bus = root_device_register("isa");
- if (IS_ERR(isa_bus)) {
- error = PTR_ERR(isa_bus);
- bus_unregister(&isa_bus_type);
- }
+ if (error)
+ return error;
+
+ isa_bus = root_device_register("isa");
+ if (IS_ERR(isa_bus)) {
+ bus_unregister(&isa_bus_type);
+ return PTR_ERR(isa_bus);
}
- return error;
+
+ return 0;
}
postcore_initcall(isa_bus_init);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] isa: refactor code to remove nested blocks
2026-06-24 12:20 [PATCH] isa: refactor code to remove nested blocks Syed Nayyar Waris
@ 2026-06-26 11:13 ` William Breathitt Gray
0 siblings, 0 replies; 2+ messages in thread
From: William Breathitt Gray @ 2026-06-26 11:13 UTC (permalink / raw)
To: Syed Nayyar Waris
Cc: William Breathitt Gray, gregkh, rafael, dakr, driver-core,
linux-kernel
On Wed, Jun 24, 2026 at 05:50:49PM +0530, Syed Nayyar Waris wrote:
> Remove nested blocks in isa_bus_init()
>
> Suggested-by: William Breathitt Gray <wbg@kernel.org>
> Signed-off-by: Syed Nayyar Waris <syednwaris@gmail.com>
Hi Syed,
The patch description is just repeating the subject line. Instead, you
should explain why this cleanup improves the module (e.g. makes the code
clearer).
You should also include a Link tag pointing to the previous discussion
about this change.
Link: https://lore.kernel.org/all/20260504063518.515620-1-wbg@kernel.org/
Regardless, I agree with the code changes in this patch so here is my
Ack.
Acked-by: William Breathitt Gray <wbg@kernel.org>
> ---
> drivers/base/isa.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/base/isa.c b/drivers/base/isa.c
> index 5887e4211f80..4e9f68080f39 100644
> --- a/drivers/base/isa.c
> +++ b/drivers/base/isa.c
> @@ -166,14 +166,16 @@ static int __init isa_bus_init(void)
> int error;
>
> error = bus_register(&isa_bus_type);
> - if (!error) {
> - isa_bus = root_device_register("isa");
> - if (IS_ERR(isa_bus)) {
> - error = PTR_ERR(isa_bus);
> - bus_unregister(&isa_bus_type);
> - }
> + if (error)
> + return error;
> +
> + isa_bus = root_device_register("isa");
> + if (IS_ERR(isa_bus)) {
> + bus_unregister(&isa_bus_type);
> + return PTR_ERR(isa_bus);
> }
> - return error;
> +
> + return 0;
> }
>
> postcore_initcall(isa_bus_init);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-26 11:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-24 12:20 [PATCH] isa: refactor code to remove nested blocks Syed Nayyar Waris
2026-06-26 11:13 ` William Breathitt Gray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox