Linux driver-core infrastructure
 help / color / mirror / Atom feed
* [PATCH] base: soc: fixup sys_soc.h kernel-doc warnings
@ 2026-07-23 21:41 Randy Dunlap
  2026-07-27 20:38 ` Danilo Krummrich
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2026-07-23 21:41 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Bjorn Andersson, Greg Kroah-Hartman,
	Rafael J. Wysocki, Danilo Krummrich, driver-core

- add function return values in 2 places
- use the correct function parameter name in kernel-doc comments

to avoid these kernel-doc warnings:

Warning: include/linux/sys_soc.h:25 No description found for return value of 'soc_device_register'
Warning: include/linux/sys_soc.h:37 No description found for return value of 'soc_device_to_device'
Warning: include/linux/sys_soc.h:31 function parameter 'soc_dev' not described in 'soc_device_unregister'
Warning: include/linux/sys_soc.h:31 Excess function parameter 'dev' description in 'soc_device_unregister'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: driver-core@lists.linux.dev

 include/linux/sys_soc.h |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

--- linux-next-20260722.orig/include/linux/sys_soc.h
+++ linux-next-20260722/include/linux/sys_soc.h
@@ -21,19 +21,26 @@ struct soc_device_attribute {
 /**
  * soc_device_register - register SoC as a device
  * @soc_plat_dev_attr: Attributes passed from platform to be attributed to a SoC
+ *
+ * Returns:
+ * - %NULL if the SoC bus is not yet registered;
+ * - on success, the newly allocated &struct soc_device pointer;
+ * - on failure, a negative error code as an ERR_PTR().
  */
 struct soc_device *soc_device_register(
 	struct soc_device_attribute *soc_plat_dev_attr);
 
 /**
  * soc_device_unregister - unregister SoC device
- * @dev: SoC device to be unregistered
+ * @soc_dev: SoC device to be unregistered
  */
 void soc_device_unregister(struct soc_device *soc_dev);
 
 /**
  * soc_device_to_device - helper function to fetch struct device
  * @soc: Previously registered SoC device container
+ *
+ * Returns: &struct device pointer for this @soc
  */
 struct device *soc_device_to_device(struct soc_device *soc);
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] base: soc: fixup sys_soc.h kernel-doc warnings
  2026-07-23 21:41 [PATCH] base: soc: fixup sys_soc.h kernel-doc warnings Randy Dunlap
@ 2026-07-27 20:38 ` Danilo Krummrich
  0 siblings, 0 replies; 2+ messages in thread
From: Danilo Krummrich @ 2026-07-27 20:38 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-kernel, Bjorn Andersson, Greg Kroah-Hartman,
	Rafael J . Wysocki, Danilo Krummrich, driver-core

On Thu, 23 Jul 2026 14:41:18 -0700, Randy Dunlap wrote:
> [PATCH] base: soc: fixup sys_soc.h kernel-doc warnings

Applied, thanks!

  Branch: driver-core-testing
  Tree:   git://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git

[1/1] base: soc: fixup sys_soc.h kernel-doc warnings
      commit: 1c2c8484b9de

The patch will appear in the next linux-next integration (typically within 24
hours on weekdays).

The patch is in the driver-core-testing branch and will be promoted to
driver-core-next after validation.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-27 20:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 21:41 [PATCH] base: soc: fixup sys_soc.h kernel-doc warnings Randy Dunlap
2026-07-27 20:38 ` Danilo Krummrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox