Linux driver-core infrastructure
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Ankit Agrawal <ankita@nvidia.com>
Cc: "linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"driver-core@lists.linux.dev" <driver-core@lists.linux.dev>,
	Alistair Francis <alistair.francis@wdc.com>,
	Lukas Wunner <lukas@wunner.de>,
	Donald Hunter <donald.hunter@gmail.com>,
	"aik@amd.com" <aik@amd.com>, Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH 01/15] netlink: specs: Introduce multi-message blobs for SPDM
Date: Mon, 3 Aug 2026 09:35:56 -0700	[thread overview]
Message-ID: <20260803093556.0ef56084@kernel.org> (raw)
In-Reply-To: <SAWPR12MB9992679DEB9AFB41A21B116FDBB0D62@SAWPR12MB999267.namprd12.prod.outlook.com>

On Sun, 2 Aug 2026 17:58:06 +0000 Ankit Agrawal wrote:
> > I don't like this, sorry. You need to come up with something outside
> > of netlink or more netlink-y.  
> 
> Hi Jakub, picking this up and continuing on with the Dan's work.
> 
> In an earlier discussion [1], two options were mentioned.
> 
> > Alright, so to make this more Netlink-y you can either:
>   >  - delete the F_MULTI and replicate other attrs in each message and
>   >    add an offset attr; this will make each message in the dump more
>   >    standalone.
>   >  - keep the F_MULTI but object_val has to be a multi-attr, and then
>   >    we have to teach YNL to correctly append the attrs.  
> 
> So I'll update to the first option of standalone messages with an offset attribute.
> i.e. every dump message with a new offset for the chunk it carries and with
> reassembly left to the consumer. I suppose that aligns with your preference?
> 
> [1] https://lore.kernel.org/all/20260318170014.6650d2bf@kernel.org/

Yes, cleanly building the blob in netlink is going to be tough.
First option would be uncontroversial from Netlink PoV, AFAICT.
But also please spend a bit of time on trying to come up with
a better way of moving the blobs.

  reply	other threads:[~2026-08-03 16:35 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-05 22:08 [PATCH 00/15] Device Evidence and Trust for PCI Security Protocol (TDISP) Dan Williams
2026-07-05 22:08 ` [PATCH 01/15] netlink: specs: Introduce multi-message blobs for SPDM Dan Williams
2026-07-08 11:13   ` Donald Hunter
2026-07-11  1:43     ` Dan Williams (nvidia)
2026-07-08 13:23   ` Donald Hunter
2026-07-22  1:20   ` Jakub Kicinski
2026-08-02 17:58     ` Ankit Agrawal
2026-08-03 16:35       ` Jakub Kicinski [this message]
2026-07-05 22:08 ` [PATCH 02/15] tools: ynl: Teach pyynl to handle blobs Dan Williams
2026-07-08 13:48   ` Donald Hunter
2026-07-05 22:08 ` [PATCH 03/15] tools: ynl: Teach ynl_gen_c to validate and dump 'blob' attributes Dan Williams
2026-07-05 22:08 ` [PATCH 04/15] device core: Introduce "device evidence" over netlink Dan Williams
2026-07-08 13:22   ` Donald Hunter
2026-07-05 22:08 ` [PATCH 05/15] device core: Add "device evidence" 'validate' command Dan Williams
2026-07-05 22:08 ` [PATCH 06/15] PCI/TSM: Add device evidence support Dan Williams
2026-07-08  5:00   ` Alexey Kardashevskiy
2026-07-08 18:25     ` Dan Williams (nvidia)
2026-07-05 22:08 ` [PATCH 07/15] modules: Document the global async_probe parameter Dan Williams
2026-07-17 13:44   ` Nikolay Borisov
2026-07-05 22:08 ` [PATCH 08/15] device core: Initial device trust infrastructure Dan Williams
2026-07-06 13:45   ` Jason Gunthorpe
2026-07-05 22:08 ` [PATCH 09/15] PCI, device core: Move "untrusted" concept to DEVICE_TRUST_ADVERSARY Dan Williams
2026-07-06 13:49   ` Jason Gunthorpe
2026-07-07 13:04   ` Robin Murphy
2026-07-05 22:08 ` [PATCH 10/15] PCI/TSM: Add device interface security LOCKED support Dan Williams
2026-07-05 22:08 ` [PATCH 11/15] PCI/TSM: Add device interface security RUN support Dan Williams
2026-07-05 22:08 ` [PATCH 12/15] PCI/TSM: Add device interface security DMA enable/disable Dan Williams
2026-07-05 22:08 ` [PATCH 13/15] PCI, device core: Add private memory access for DEVICE_TRUST_TCB Dan Williams
2026-07-06 12:42   ` Aneesh Kumar K.V
2026-07-08 18:06     ` Dan Williams (nvidia)
2026-07-08 18:10       ` Aneesh Kumar K.V
2026-07-09  6:32   ` Alexey Kardashevskiy
2026-07-09  7:38     ` Alexey Kardashevskiy
2026-07-05 22:08 ` [PATCH 14/15] PCI/TSM: Create MMIO descriptors via TDISP Report Dan Williams
2026-07-08  9:49   ` Alexey Kardashevskiy
2026-07-05 22:08 ` [PATCH 15/15] PCI/TSM: Add relative MMIO offset support? Dan Williams
2026-07-08  2:25   ` Alexey Kardashevskiy
2026-07-08 18:05     ` Dan Williams (nvidia)
2026-07-06 12:51 ` [PATCH 00/15] Device Evidence and Trust for PCI Security Protocol (TDISP) Jason Gunthorpe
2026-07-06 20:55   ` Dan Williams (nvidia)
2026-07-07 12:43     ` Jason Gunthorpe
2026-07-08  0:12       ` Dan Williams (nvidia)
2026-07-08 14:31         ` Jason Gunthorpe
2026-07-09  2:45           ` Dan Williams (nvidia)
2026-07-09 13:36             ` Jason Gunthorpe
2026-07-15  9:04               ` Alexey Kardashevskiy
2026-07-16 18:51                 ` Jason Gunthorpe
2026-07-28  8:20 ` Alexey Kardashevskiy
2026-07-28 23:29   ` Jason Gunthorpe
2026-08-04  1:48     ` Xu Yilun
2026-08-04 20:33       ` Ankit Agrawal
2026-08-05 17:43         ` Xu Yilun
2026-08-05  0:55       ` Jason Gunthorpe
2026-07-29  1:57   ` Ankit Agrawal
2026-08-02 18:12   ` Ankit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260803093556.0ef56084@kernel.org \
    --to=kuba@kernel.org \
    --cc=aik@amd.com \
    --cc=alistair.francis@wdc.com \
    --cc=ankita@nvidia.com \
    --cc=donald.hunter@gmail.com \
    --cc=driver-core@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox