Linux driver-core infrastructure
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Danilo Krummrich <dakr@kernel.org>
Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] w1: use match() callback instead of hardwiring dev->driver
Date: Tue, 8 Sep 2026 16:49:05 +0200	[thread overview]
Message-ID: <2083d2e3-9e59-4c70-a79c-d8133316769f@kernel.org> (raw)
In-Reply-To: <20260820225430.1847356-1-dakr@kernel.org>

On 21/08/2026 00:54, Danilo Krummrich wrote:
>  static const struct bus_type w1_bus_type = {
>  	.name = "w1",
> +	.match = w1_match,
>  	.uevent = w1_uevent,
>  };
>  
>  struct device_driver w1_master_driver = {
>  	.name = "w1_master_driver",
>  	.bus = &w1_bus_type,
> -	.probe = w1_master_probe,
>  };
>  
>  struct device w1_master_device = {
>  	.parent = NULL,
>  	.bus = &w1_bus_type,
> +	.type = &w1_master_device_type,
>  	.init_name = "w1 bus master",
> -	.driver = &w1_master_driver,
>  	.release = &w1_master_release
>  };
>  
> @@ -195,8 +208,8 @@ static struct device_driver w1_slave_driver = {
>  struct device w1_slave_device = {
>  	.parent = NULL,
>  	.bus = &w1_bus_type,
> +	.type = &w1_slave_device_type,

This code is disabled, so probably should be cleaned up before we start
improving it.


Best regards,
Krzysztof

  parent reply	other threads:[~2026-09-08 14:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 22:54 [PATCH 1/3] w1: use match() callback instead of hardwiring dev->driver Danilo Krummrich
2026-08-20 22:54 ` [PATCH 2/3] w1: move slave uevent into w1_slave_device_type Danilo Krummrich
2026-09-08 14:54   ` Krzysztof Kozlowski
2026-09-08 19:12     ` Danilo Krummrich
2026-08-20 22:54 ` [PATCH 3/3] w1: stop using struct device template for master devices Danilo Krummrich
2026-09-08 14:49 ` Krzysztof Kozlowski [this message]
2026-09-08 19:07   ` [PATCH 1/3] w1: use match() callback instead of hardwiring dev->driver Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2083d2e3-9e59-4c70-a79c-d8133316769f@kernel.org \
    --to=krzk@kernel.org \
    --cc=dakr@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox