Re: [PATCH] debugfs: Fix lockdown check for mmap_prepare

Re: [PATCH] debugfs: Fix lockdown check for mmap_prepare

[Lorenzo Stoakes]

-cc wrong email

(Please make sure to use my correct email address - ljs@kernel.org -
 I usually do not see emails sent to the incorrect one)

+From: Chun-Yi Lee <jlee@suse.com>

(You're sending from a different email address so you need to explicitly
add a From: xxx tag to match the S-o-b at the top of the message)


On Fri, Jun 12, 2026 at 01:54:55PM +0800, Chun-Yi Lee wrote:
> Commit 651fdda8406d ("relay: update relay to use mmap_prepare")
> changed the `mmap` file operation to `mmap_prepare` for relayfs, but
> the lockdown check in debugfs was not updated accordingly.
>
> This prevents debugfs from being locked down when the kernel is in
> integrity mode if a file uses `mmap_prepare` but not `mmap`.
>
> Update the lockdown check to look for `mmap_prepare` instead of `mmap`
> to fix this.
>
> Fixes: 651fdda8406d ("relay: update relay to use mmap_prepare")

You need to explicitly add:

Cc: stable@vger.kernel.org

As we will want this backported.

> Signed-off-by: Chun-Yi Lee <jlee@suse.com>

I think the idea is correct, but needs tweaking to cover _both_ mmap and
mmap_prepare, until the mmap_prepare conversion is complete, see below.

> Cc: David Howells <dhowells@redhat.com>
> Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Rafael J. Wysocki <rafael@kernel.org>
> Cc: Matthew Garrett <matthewgarrett@google.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Cc: driver-core@lists.linux.dev
> Cc: linux-kernel@vger.kernel.org
> ---
>  fs/debugfs/file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
> index edd6aafbfbaa..d5e187895dd8 100644
> --- a/fs/debugfs/file.c
> +++ b/fs/debugfs/file.c
> @@ -273,7 +273,7 @@ static int debugfs_locked_down(struct inode *inode,
>  	    (!real_fops ||
>  	     (!real_fops->unlocked_ioctl &&
>  	      !real_fops->compat_ioctl &&
> -	      !real_fops->mmap)))
> +	      !real_fops->mmap_prepare)))

This is not only applicable to relayfs.

So while we both have mmap and mmap_prepare, this should be:

-	      !real_fops->mmap)))
+	      !real_fops->mmap &&
+	      !real_fops->mmap_prepare)))


>  		return 0;
>
>  	if (security_locked_down(LOCKDOWN_DEBUGFS))
> --
> 2.43.0
>

Thanks, Lorenzo

Re: [PATCH] debugfs: Fix lockdown check for mmap_prepare

[joeyli]

Hi Lorenzo, 

Thanks for your review!

On Fri, Jun 12, 2026 at 08:28:29AM +0100, Lorenzo Stoakes wrote:
> -cc wrong email
> 
> (Please make sure to use my correct email address - ljs@kernel.org -
>  I usually do not see emails sent to the incorrect one)
> 
> +From: Chun-Yi Lee <jlee@suse.com>
> 
> (You're sending from a different email address so you need to explicitly
> add a From: xxx tag to match the S-o-b at the top of the message)
>

I will use your kernel.org email address and put From: tag.
 
> 
> On Fri, Jun 12, 2026 at 01:54:55PM +0800, Chun-Yi Lee wrote:
> > Commit 651fdda8406d ("relay: update relay to use mmap_prepare")
> > changed the `mmap` file operation to `mmap_prepare` for relayfs, but
> > the lockdown check in debugfs was not updated accordingly.
> >
> > This prevents debugfs from being locked down when the kernel is in
> > integrity mode if a file uses `mmap_prepare` but not `mmap`.
> >
> > Update the lockdown check to look for `mmap_prepare` instead of `mmap`
> > to fix this.
> >
> > Fixes: 651fdda8406d ("relay: update relay to use mmap_prepare")
> 
> You need to explicitly add:
> 
> Cc: stable@vger.kernel.org
> 
> As we will want this backported.
>

I will add cc. to stable mailing list.
 
> > Signed-off-by: Chun-Yi Lee <jlee@suse.com>
> 
> I think the idea is correct, but needs tweaking to cover _both_ mmap and
> mmap_prepare, until the mmap_prepare conversion is complete, see below.
> 
> > Cc: David Howells <dhowells@redhat.com>
> > Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> > cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> > cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Rafael J. Wysocki <rafael@kernel.org>
> > Cc: Matthew Garrett <matthewgarrett@google.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Danilo Krummrich <dakr@kernel.org>
> > Cc: driver-core@lists.linux.dev
> > Cc: linux-kernel@vger.kernel.org
> > ---
> >  fs/debugfs/file.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
> > index edd6aafbfbaa..d5e187895dd8 100644
> > --- a/fs/debugfs/file.c
> > +++ b/fs/debugfs/file.c
> > @@ -273,7 +273,7 @@ static int debugfs_locked_down(struct inode *inode,
> >  	    (!real_fops ||
> >  	     (!real_fops->unlocked_ioctl &&
> >  	      !real_fops->compat_ioctl &&
> > -	      !real_fops->mmap)))
> > +	      !real_fops->mmap_prepare)))
> 
> This is not only applicable to relayfs.
> 
> So while we both have mmap and mmap_prepare, this should be:
> 
> -	      !real_fops->mmap)))
> +	      !real_fops->mmap &&
> +	      !real_fops->mmap_prepare)))
>

Yes, thanks a lot! I will send v2 patch.

Joey Lee