[PATCH] libcommon: disable _FORTIFY_SOURCE

[PATCH] libcommon: disable _FORTIFY_SOURCE

[Nick Alcock]

This is incompatible with the dynamic-length-string trick we pull in
the DOF parser (which is in any case seccomp-jailed).

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
---
 libcommon/Build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcommon/Build b/libcommon/Build
index 50aa4ed88f8c3..fd54dc044f9af 100644
--- a/libcommon/Build
+++ b/libcommon/Build
@@ -8,6 +8,6 @@ LIBS += libcommon
 
 libcommon_TARGET = libcommon
 libcommon_DIR := $(current-dir)
-libcommon_CPPFLAGS := -Ilibcommon -Ilibproc
+libcommon_CPPFLAGS := -Ilibcommon -Ilibproc -U_FORTIFY_SOURCE
 libcommon_SOURCES = dof_parser.c dof_parser_host.c dt_list.c
 libcommon_LIBSOURCES = libcommon

base-commit: 6c5f67cc8ea1d694da8043c8f5aeb2f97b69997a
prerequisite-patch-id: 27ade1c234620c8ed86991c2311a7887e935e1c0
-- 
2.44.0.273.ge0bd14271f

Re: [PATCH] libcommon: disable _FORTIFY_SOURCE

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh@oracle.com>
but "This" (the opening word in the commit message) is a little ambiguous.

On 4/25/24 12:40, Nick Alcock wrote:
> This is incompatible with the dynamic-length-string trick we pull in
> the DOF parser (which is in any case seccomp-jailed).
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> ---
>   libcommon/Build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libcommon/Build b/libcommon/Build
> index 50aa4ed88f8c3..fd54dc044f9af 100644
> --- a/libcommon/Build
> +++ b/libcommon/Build
> @@ -8,6 +8,6 @@ LIBS += libcommon
>   
>   libcommon_TARGET = libcommon
>   libcommon_DIR := $(current-dir)
> -libcommon_CPPFLAGS := -Ilibcommon -Ilibproc
> +libcommon_CPPFLAGS := -Ilibcommon -Ilibproc -U_FORTIFY_SOURCE
>   libcommon_SOURCES = dof_parser.c dof_parser_host.c dt_list.c
>   libcommon_LIBSOURCES = libcommon
>
> base-commit: 6c5f67cc8ea1d694da8043c8f5aeb2f97b69997a
> prerequisite-patch-id: 27ade1c234620c8ed86991c2311a7887e935e1c0

Re: [PATCH] libcommon: disable _FORTIFY_SOURCE

[Nick Alcock]

On 25 Apr 2024, Eugene Loh uttered the following:

> Reviewed-by: Eugene Loh <eugene.loh@oracle.com>
> but "This" (the opening word in the commit message) is a little ambiguous.

How? There's only one possible referent, _FORTIFY_SOURCE. (The subject
line is part of the commit log too!)

> On 4/25/24 12:40, Nick Alcock wrote:
>> This is incompatible with the dynamic-length-string trick we pull in
>> the DOF parser (which is in any case seccomp-jailed).
>>
>> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>> ---
>>   libcommon/Build | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libcommon/Build b/libcommon/Build
>> index 50aa4ed88f8c3..fd54dc044f9af 100644
>> --- a/libcommon/Build
>> +++ b/libcommon/Build
>> @@ -8,6 +8,6 @@ LIBS += libcommon
>>     libcommon_TARGET = libcommon
>>   libcommon_DIR := $(current-dir)
>> -libcommon_CPPFLAGS := -Ilibcommon -Ilibproc
>> +libcommon_CPPFLAGS := -Ilibcommon -Ilibproc -U_FORTIFY_SOURCE
>>   libcommon_SOURCES = dof_parser.c dof_parser_host.c dt_list.c
>>   libcommon_LIBSOURCES = libcommon
>>
>> base-commit: 6c5f67cc8ea1d694da8043c8f5aeb2f97b69997a
>> prerequisite-patch-id: 27ade1c234620c8ed86991c2311a7887e935e1c0

-- 
NULL && (void)

Re: [PATCH] libcommon: disable _FORTIFY_SOURCE

[Eugene Loh]

On 4/26/24 07:30, Nick Alcock wrote:

> On 25 Apr 2024, Eugene Loh uttered the following:
>
>> Reviewed-by: Eugene Loh <eugene.loh@oracle.com>
>> but "This" (the opening word in the commit message) is a little ambiguous.
> How? There's only one possible referent, _FORTIFY_SOURCE. (The subject
> line is part of the commit log too!)

Perhaps.  Not a big deal.  But if one says "disable _FORTIFY_SOURCE" and 
then "this", does "this" refer to "disable _FORTIFY_SOURCE"? Why not 
just s/This/_FORTIFY_SOURCE/?

>> On 4/25/24 12:40, Nick Alcock wrote:
>>> This is incompatible with the dynamic-length-string trick we pull in
>>> the DOF parser (which is in any case seccomp-jailed).
>>>
>>> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>>> ---
>>>    libcommon/Build | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libcommon/Build b/libcommon/Build
>>> index 50aa4ed88f8c3..fd54dc044f9af 100644
>>> --- a/libcommon/Build
>>> +++ b/libcommon/Build
>>> @@ -8,6 +8,6 @@ LIBS += libcommon
>>>      libcommon_TARGET = libcommon
>>>    libcommon_DIR := $(current-dir)
>>> -libcommon_CPPFLAGS := -Ilibcommon -Ilibproc
>>> +libcommon_CPPFLAGS := -Ilibcommon -Ilibproc -U_FORTIFY_SOURCE
>>>    libcommon_SOURCES = dof_parser.c dof_parser_host.c dt_list.c
>>>    libcommon_LIBSOURCES = libcommon
>>>
>>> base-commit: 6c5f67cc8ea1d694da8043c8f5aeb2f97b69997a
>>> prerequisite-patch-id: 27ade1c234620c8ed86991c2311a7887e935e1c0