Re: [PATCH] build: install sdt*.h in /usr/lib64/dtrace/include/sys

[Nick Alcock <nick.alcock@oracle.com>]

On 23 May 2024, Kris Van Hees verbalised:

> Can you split the move of sdt.h and sdt_internal.h into its own patch
> please?  And I guess the pkg-config stuff in a follw-up patch?  Still
> need to look into that a bit more because I have reservations.  But
> the moving of the header files is definitely something that should be
> in its own patch.

I put them in the same commit for a reason: doing otherwise would break
the installed testsuite in the intermediate commit, and I don't want to
implement *two distinct* mechanisms for locating the headers when we
already have one that works perfectly well (pkg-config).

(Also, splitting them up runs the risk of your integrating one without
the other, and they really do go together.)

> Introducing pkg-config as a mechanism that people can use is a separate
> thing (and as far as I can see, could use some extra work anyway because
> e.g. runtest.sh still has other absolute paths in it that cause failures
> when the DTrace build is configured to install things in non-standard
> locations).

Well, yes, I didn't try to make the *entire build* relocatable in this
patch. That really *would* have been too much for one commit.