Re: [PATCH] build: install sdt*.h in /usr/lib64/dtrace/include/sys

[Kris Van Hees <kris.van.hees@oracle.com>]

On Thu, May 23, 2024 at 07:49:26PM +0100, Nick Alcock wrote:
> On 23 May 2024, Kris Van Hees verbalised:
> 
> > Can you split the move of sdt.h and sdt_internal.h into its own patch
> > please?  And I guess the pkg-config stuff in a follw-up patch?  Still
> > need to look into that a bit more because I have reservations.  But
> > the moving of the header files is definitely something that should be
> > in its own patch.
> 
> I put them in the same commit for a reason: doing otherwise would break
> the installed testsuite in the intermediate commit, and I don't want to
> implement *two distinct* mechanisms for locating the headers when we
> already have one that works perfectly well (pkg-config).

Do the first patch with the moving of the sdt header files, adding an
explicit -I/usr/lib64/dtrace/include to the CFLAGS, and the testsuite
should work perfectly fine with the file move.  That is hardly another
mechanism.

> (Also, splitting them up runs the risk of your integrating one without
> the other, and they really do go together.)

They are two different things - I mentioned that from the very beginning
of the discussions to deal with the sys/sdt.h conflict,  Please split it
into two patches.  The pkg-config support is bigger than just this sdt
header file move.

> > Introducing pkg-config as a mechanism that people can use is a separate
> > thing (and as far as I can see, could use some extra work anyway because
> > e.g. runtest.sh still has other absolute paths in it that cause failures
> > when the DTrace build is configured to install things in non-standard
> > locations).
> 
> Well, yes, I didn't try to make the *entire build* relocatable in this
> patch. That really *would* have been too much for one commit.

Yet the purpose of introducing pkg-config is to deal with installs in
non-standard locations.  If we are not caring about that right now, then
there is no need to introduce pkg-config just yet either, and definitely
not as part of the patch of moving the sdt header files.