Re: [DTrace-devel] [PATCH 01/14] Move comment closer to the code it describes

[Kris Van Hees <kris.van.hees@oracle.com>]

On Tue, Jun 04, 2024 at 02:11:00PM -0400, eugene.loh--- via DTrace-devel wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  libdtrace/dt_prov_uprobe.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/libdtrace/dt_prov_uprobe.c b/libdtrace/dt_prov_uprobe.c
> index b712c589..afc1f628 100644
> --- a/libdtrace/dt_prov_uprobe.c
> +++ b/libdtrace/dt_prov_uprobe.c
> @@ -337,15 +337,16 @@ static void enable(dtrace_hdl_t *dtp, dt_probe_t *prp, int is_usdt)
>  
>  	/*
>  	 * We need to enable the underlying probes (if not enabled yet).
> -	 *
> -	 * If necessary, we need to enable is-enabled probes too (if they
> -	 * exist).
>  	 */
>  	for (pup = prp->prv_data; pup != NULL; pup = dt_list_next(pup)) {
>  		dt_probe_t *uprp = pup->probe;
>  		dt_probe_enable(dtp, uprp);
>  	}
>  
> +	/*
> +	 * If necessary, we need to enable is-enabled probes too (if they
> +	 * exist).
> +	 */
>  	if (is_usdt) {
>  		dtrace_probedesc_t pd;
>  		dt_probe_t *iep;
> -- 
> 2.18.4
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel@oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel