From: Kris Van Hees <kris.van.hees@oracle.com>
To: Eugene Loh <eugene.loh@oracle.com>
Cc: Nick Alcock <nick.alcock@oracle.com>, dtrace@lists.linux.dev
Subject: Re: [DTrace-devel] [PATCH 08/14] Test: caller and stackdepth tests for ip provider
Date: Wed, 25 Jun 2025 00:15:58 -0400 [thread overview]
Message-ID: <aFt3/kgGGDZi6+ft@oracle.com> (raw)
In-Reply-To: <fd0c08ee-8efd-4728-fb5f-06e354b2ee1e@oracle.com>
On Mon, Jun 16, 2025 at 11:38:05PM -0400, Eugene Loh wrote:
> On 6/13/25 10:51, Nick Alcock wrote:
>
> > On 22 May 2025, eugene loh spake thusly:
> >
> > > From: Eugene Loh <eugene.loh@oracle.com>
> > >
> > > Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
> > Reviewed-by: Nick Alcock <nick.alcock@oracle.com>
> >
> > with the microscopic caveat below.
> >
> > > diff --git a/test/unittest/variables/bvar/perlping.pl b/test/unittest/variables/bvar/perlping.pl
> > > new file mode 100755
> > > index 000000000..97c9b09e9
> > > --- /dev/null
> > > +++ b/test/unittest/variables/bvar/perlping.pl
> > > @@ -0,0 +1,8 @@
> > > +#!/usr/bin/perl -w
> > > +# Oracle Linux DTrace.
> > > +# Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
> > > +# Licensed under the Universal Permissive License v 1.0 as shown at
> > > +# http://oss.oracle.com/licenses/upl.
> > > +use Net::Ping;
> > > +my $p = Net::Ping->new(${ARGV[0]}, 5, 56);
> > > +$p->ping(${ARGV[1]});
> > Is there some reason we can't just use $testdir/../../ip/perlping.pl and
> > avoid duplicating this?
>
>
> Thanks. Okay, I did this.
>
Can you please post the updated v2 ASAP so I can merge the series?
next prev parent reply other threads:[~2025-06-25 4:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 18:01 [PATCH 01/14] Fix stack-skip counts for caller and stackdepth eugene.loh
2025-05-22 18:01 ` [PATCH 02/14] Add stack-skip frame count for rawtp provider eugene.loh
2025-06-13 14:35 ` Nick Alcock
2025-05-22 18:01 ` [PATCH 03/14] Test: remove unnecessary "unstable" tag eugene.loh
2025-06-13 14:35 ` [DTrace-devel] " Nick Alcock
2025-05-22 18:01 ` [PATCH 04/14] Test: caller and stackdepth tests for fbt provider eugene.loh
2025-06-13 14:40 ` [DTrace-devel] " Nick Alcock
2025-06-16 19:43 ` Eugene Loh
2025-06-25 4:14 ` Kris Van Hees
2025-05-22 18:01 ` [PATCH 05/14] Test: caller and stackdepth tests for dtrace provider eugene.loh
2025-06-13 14:42 ` Nick Alcock
2025-05-22 18:01 ` [PATCH 06/14] Test: caller and stackdepth tests for rawtp provider eugene.loh
2025-06-13 14:45 ` Nick Alcock
2025-05-22 18:01 ` [PATCH 07/14] Test: caller and stackdepth tests for cpc provider eugene.loh
2025-06-13 14:48 ` [DTrace-devel] " Nick Alcock
2025-05-22 18:01 ` [PATCH 08/14] Test: caller and stackdepth tests for ip provider eugene.loh
2025-06-13 14:51 ` [DTrace-devel] " Nick Alcock
2025-06-17 3:38 ` Eugene Loh
2025-06-25 4:15 ` Kris Van Hees [this message]
2025-05-22 18:01 ` [PATCH 09/14] Test: caller and stackdepth tests for profile provider eugene.loh
2025-06-13 14:52 ` [DTrace-devel] " Nick Alcock
2025-05-22 18:01 ` [PATCH 10/14] Test: caller and stackdepth tests for sched provider eugene.loh
2025-06-13 14:52 ` Nick Alcock
2025-05-22 18:01 ` [PATCH 11/14] Test: caller and stackdepth tests for proc provider eugene.loh
2025-06-13 14:53 ` Nick Alcock
2025-06-15 17:50 ` Eugene Loh
2025-06-19 12:52 ` Nick Alcock
2025-06-25 4:18 ` Kris Van Hees
2025-05-22 18:01 ` [PATCH 12/14] Test: caller and stackdepth tests for rawfbt provider eugene.loh
2025-06-13 14:54 ` [DTrace-devel] " Nick Alcock
2025-06-17 23:17 ` Eugene Loh
2025-05-22 18:01 ` [PATCH 13/14] Test: caller and stackdepth tests for io provider eugene.loh
2025-06-13 14:56 ` [DTrace-devel] " Nick Alcock
2025-05-22 18:01 ` [PATCH 14/14] Test: caller and stackdepth tests for lockstat provider eugene.loh
2025-06-13 14:57 ` Nick Alcock
2025-06-13 14:33 ` [PATCH 01/14] Fix stack-skip counts for caller and stackdepth Nick Alcock
2025-06-16 19:21 ` Eugene Loh
2025-06-19 13:03 ` Nick Alcock
2025-06-19 16:20 ` Kris Van Hees
2025-06-19 16:32 ` Kris Van Hees
2025-06-23 14:04 ` Nick Alcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFt3/kgGGDZi6+ft@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
--cc=nick.alcock@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox