public inbox for dwarves@vger.kernel.org
 help / color / mirror / Atom feed
From: "Alexis Lothoré" <alexis.lothore@bootlin.com>
To: "Alan Maguire" <alan.maguire@oracle.com>,
	"Ihor Solodrai" <ihor.solodrai@linux.dev>,
	<dwarves@vger.kernel.org>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: <bpf@vger.kernel.org>, "Alexei Starovoitov" <ast@fb.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Bastien Curutchet" <bastien.curutchet@bootlin.com>,
	<ebpf@linuxfoundation.org>
Subject: Re: [PATCH v3 2/3] tests: add some tests validating skipped functions due to uncertain arg location
Date: Tue, 15 Jul 2025 10:04:59 +0200	[thread overview]
Message-ID: <DBCH1MVGI5EV.JODF0DE5B063@bootlin.com> (raw)
In-Reply-To: <680c6507-af5f-41be-8823-c8c9dfceaf5f@oracle.com>

On Wed Jul 9, 2025 at 6:21 PM CEST, Alan Maguire wrote:
> On 07/07/2025 20:36, Ihor Solodrai wrote:
>> On 7/7/25 7:14 AM, Alexis Lothoré wrote:
>>> On Mon Jul 7, 2025 at 4:02 PM CEST, Alexis Lothoré (eBPF Foundation)
>>> wrote:

[...]

>> I think a proper fix for this is differentiating two variants of
>> LSK__STOP_LOADING: stop because of an error, and stop because there is
>> nothing else to do. That would require a bit of refactoring.
>> 
>> Alan, Arnaldo, what do you think?
>>
>
> Would it suffice to treat LSK__STOP_LOADING as an error in the BTF
> encoding case, and not otherwise? That's a bit of hack; ideally I
> suppose we'd introduce LSK__ABORT (like DWARF_CB_ABORT) and use it for
> all the failure modes, reserving LSK__STOP_LOADING for cases where we
> are done processing rather than we met an error.

Ihor, Alan, is anyone one of you planning to work on it ? If not, do you
want me take a look and implement one of the solution suggested above ? I
guess it's best to aim for Alan's second suggestion first (introducing a
new LSK enum to represent a failure), otherwise the simpler solution
distinguishing reasons for LSK__STOP_LOADING.

Alexis

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2025-07-15  8:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 14:02 [PATCH v3 0/3] btf_encoder: do not encode functions consuming packed structs on stack Alexis Lothoré (eBPF Foundation)
2025-07-07 14:02 ` [PATCH v3 1/3] btf_encoder: skip functions consuming packed structs passed by value " Alexis Lothoré (eBPF Foundation)
2025-07-07 17:05   ` Alexei Starovoitov
2025-07-07 17:45   ` Ihor Solodrai
2025-08-04  7:13   ` Alexis Lothoré
2025-08-04  9:58   ` Jiri Olsa
2025-07-07 14:02 ` [PATCH v3 2/3] tests: add some tests validating skipped functions due to uncertain arg location Alexis Lothoré (eBPF Foundation)
2025-07-07 14:14   ` Alexis Lothoré
2025-07-07 19:36     ` Ihor Solodrai
2025-07-09 16:21       ` Alan Maguire
2025-07-15  8:04         ` Alexis Lothoré [this message]
2025-07-15 15:36           ` Ihor Solodrai
2025-08-05 15:09   ` Alan Maguire
2025-08-05 19:06     ` Alexis Lothoré
2025-08-06 11:14       ` Alan Maguire
2025-07-07 14:02 ` [PATCH v3 3/3] gitignore: ignore all the test kmod build-related files Alexis Lothoré (eBPF Foundation)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBCH1MVGI5EV.JODF0DE5B063@bootlin.com \
    --to=alexis.lothore@bootlin.com \
    --cc=acme@kernel.org \
    --cc=alan.maguire@oracle.com \
    --cc=ast@fb.com \
    --cc=bastien.curutchet@bootlin.com \
    --cc=bpf@vger.kernel.org \
    --cc=dwarves@vger.kernel.org \
    --cc=ebpf@linuxfoundation.org \
    --cc=ihor.solodrai@linux.dev \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox