From: Tyler Hicks <code@tyhicks.com>
To: Yichong Chen <chenyichong@uniontech.com>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
Kees Cook <kees@kernel.org>,
ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ecryptfs: release message context on send failure
Date: Tue, 30 Jun 2026 22:45:38 -0500 [thread overview]
Message-ID: <akSNYl2MglViekHR@yaupon> (raw)
In-Reply-To: <20260627090126.27607-1-chenyichong@uniontech.com>
On 2026-06-27 17:01:26, Yichong Chen wrote:
> ecryptfs_send_message_locked() moves a message context from the free
> list to the allocated list before sending the request to the userspace
> daemon.
>
> If ecryptfs_send_miscdev() fails, the context is left on the
> allocated list and cannot be reused. Move it back to the free list on
> failure and clear the caller's pointer.
Hi - Thanks for the fix!
>
> Fixes: 624ae5284516 ("eCryptfs: remove netlink transport")
I think the correct Fixes tag is:
Fixes: f66e883eb618 ("eCryptfs: integrate eCryptfs device handle into the module.")
Do you agree that is when this bug was first introduced?
The rest of the patch looks good to me.
Tyler
> Signed-off-by: Yichong Chen <chenyichong@uniontech.com>
> ---
> fs/ecryptfs/messaging.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c
> index 03c60f0850ca..d53c21e82365 100644
> --- a/fs/ecryptfs/messaging.c
> +++ b/fs/ecryptfs/messaging.c
> @@ -284,9 +284,16 @@ ecryptfs_send_message_locked(char *data, int data_len, u8 msg_type,
> mutex_unlock(&ecryptfs_msg_ctx_lists_mux);
> rc = ecryptfs_send_miscdev(data, data_len, *msg_ctx, msg_type, 0,
> daemon);
> - if (rc)
> + if (rc) {
> printk(KERN_ERR "%s: Error attempting to send message to "
> "userspace daemon; rc = [%d]\n", __func__, rc);
> + mutex_lock(&ecryptfs_msg_ctx_lists_mux);
> + mutex_lock(&(*msg_ctx)->mux);
> + ecryptfs_msg_ctx_alloc_to_free(*msg_ctx);
> + mutex_unlock(&(*msg_ctx)->mux);
> + mutex_unlock(&ecryptfs_msg_ctx_lists_mux);
> + *msg_ctx = NULL;
> + }
> out:
> return rc;
> }
> --
> 2.51.0
>
next prev parent reply other threads:[~2026-07-01 3:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-27 9:01 [PATCH] ecryptfs: release message context on send failure Yichong Chen
2026-07-01 3:45 ` Tyler Hicks [this message]
2026-07-01 5:25 ` Yichong Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akSNYl2MglViekHR@yaupon \
--to=code@tyhicks.com \
--cc=chenyichong@uniontech.com \
--cc=ecryptfs@vger.kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox