missing header files

missing header files

[Andreas Radke]

[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]

Using "make install" target seems to not install some of the header
files. I've run into missing ell/useful.h for recent iwd build from git
master.

Can you clarify whether all these header files should be installed when
building a distribution package and please make the Makefile install
those that are expected to be present on the system.

cp ell/*.h "$pkgdir"/usr/include/ell/ shows these additional files now:

/usr/include/ell/asn1-private.h
/usr/include/ell/cert-private.h
/usr/include/ell/dbus-private.h
/usr/include/ell/dhcp-private.h
/usr/include/ell/dhcp6-private.h
/usr/include/ell/ecc-private.h
/usr/include/ell/gvariant-private.h
/usr/include/ell/icmp6-private.h
/usr/include/ell/main-private.h
/usr/include/ell/missing.h
/usr/include/ell/net-private.h
/usr/include/ell/netlink-private.h
/usr/include/ell/pem-private.h
/usr/include/ell/private.h
/usr/include/ell/rtnl-private.h
/usr/include/ell/siphash-private.h
/usr/include/ell/time-private.h
/usr/include/ell/tls-private.h
 usr/include/ell/useful.h

-Andy
Arch Linux

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: missing header files

[Denis Kenzior]

Hi Andreas,

On 8/26/24 7:38 AM, Andreas Radke wrote:
> Using "make install" target seems to not install some of the header
> files. I've run into missing ell/useful.h for recent iwd build from git
> master.

ell/useful.h and ell/asn1-private.h are special.  They're copied from the ell 
tree when iwd is built.  Even if using shared ell, you need to setup ell as 
described in the README

> 
> Can you clarify whether all these header files should be installed when
> building a distribution package and please make the Makefile install
> those that are expected to be present on the system.
> 

These files are included in the distribution package.
[denkenz@archdev iwd]$ tar -Jtvf iwd-2.19.tar.xz | grep useful
-rw-r--r-- denkenz/denkenz   1979 2024-08-16 10:31 iwd-2.19/ell/useful.h
[denkenz@archdev iwd]$ tar -Jtvf iwd-2.19.tar.xz | grep asn1
-rw-r--r-- denkenz/denkenz   4406 2024-08-16 10:31 iwd-2.19/ell/asn1-private.h

> cp ell/*.h "$pkgdir"/usr/include/ell/ shows these additional files now:
> 
> /usr/include/ell/asn1-private.h
> /usr/include/ell/cert-private.h
> /usr/include/ell/dbus-private.h
> /usr/include/ell/dhcp-private.h
> /usr/include/ell/dhcp6-private.h
> /usr/include/ell/ecc-private.h
> /usr/include/ell/gvariant-private.h
> /usr/include/ell/icmp6-private.h
> /usr/include/ell/main-private.h
> /usr/include/ell/missing.h
> /usr/include/ell/net-private.h
> /usr/include/ell/netlink-private.h
> /usr/include/ell/pem-private.h
> /usr/include/ell/private.h
> /usr/include/ell/rtnl-private.h
> /usr/include/ell/siphash-private.h
> /usr/include/ell/time-private.h
> /usr/include/ell/tls-private.h
>   usr/include/ell/useful.h

None of these files are to be installed by ell, they're not part of the public API.

Regards,
-Denis

Re: missing header files

[Andreas Radke]

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

Am Mon, 26 Aug 2024 10:38:37 -0500
schrieb Denis Kenzior <denkenz@gmail.com>:

> Hi Andreas,
> 
> On 8/26/24 7:38 AM, Andreas Radke wrote:
>  [...]  
> 
> ell/useful.h and ell/asn1-private.h are special.  They're copied from
> the ell tree when iwd is built.  Even if using shared ell, you need
> to setup ell as described in the README
> 
>  [...]  
> 
> These files are included in the distribution package.
> [denkenz@archdev iwd]$ tar -Jtvf iwd-2.19.tar.xz | grep useful
> -rw-r--r-- denkenz/denkenz   1979 2024-08-16 10:31
> iwd-2.19/ell/useful.h [denkenz@archdev iwd]$ tar -Jtvf
> iwd-2.19.tar.xz | grep asn1 -rw-r--r-- denkenz/denkenz   4406
> 2024-08-16 10:31 iwd-2.19/ell/asn1-private.h
> 
>  [...]  
> 
> None of these files are to be installed by ell, they're not part of
> the public API.
> 
> Regards,
> -Denis
> 

Compiling is broken here when using --enable-external-ell with iwd git
master no matter if I put ell source along iwd as described in README
but succeeds with --disable-external-ell.

The README ist somewhat misleading here. When building from git and
placing ell into toplevel dir it's failing. A cp ell/ell into iwd/ is
required when building from git.

-Andy


[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 488 bytes --]