From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: fio@vger.kernel.org
Subject: Re: io_uring engine -- sqthread_poll option can't work as implemented
Date: Wed, 4 Sep 2019 14:10:22 -0600 [thread overview]
Message-ID: <0f8ba952-418c-d63d-6b3e-021cae4cfecc@kernel.dk> (raw)
In-Reply-To: <x498sr5txag.fsf@segfault.boston.devel.redhat.com>
On 9/3/19 5:49 AM, Jeff Moyer wrote:
> Jens Axboe <axboe@kernel.dk> writes:
>
>> On 8/29/19 10:38 AM, Jeff Moyer wrote:
>>> Hi,
>>>
>>> sqthread_poll requires registered files in order to work. That's not
>>> implemented in fio, and I don't see how one would go about it (but I'm
>>> not all that familiar with fio's architecture). We basically need all
>>> files to be opened before we can register them. It looks to me as
>>> though the files are opened on demand, after the io engine is
>>> initialized.
>>>
>>> Any suggestions?
>>
>> Leftover from previously, when that requirement wasn't there... Using
>> it from fio would require a little bit of footwork, but it's not
>> impossible.
>
> OK, if you can point me in the right direction, I'll take a stab at it.
I think if we impose the restriction that the total number of files used
must fit in a registered file set, it isn't too hard. Just have the
engine open the files when it starts, and provide a new ->open_file()
(and ->close_file()) in the engine ops.
I'll take a stab at it.
--
Jens Axboe
next prev parent reply other threads:[~2019-09-04 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 16:38 io_uring engine -- sqthread_poll option can't work as implemented Jeff Moyer
2019-08-31 3:18 ` Jens Axboe
2019-09-03 11:49 ` Jeff Moyer
2019-09-04 20:10 ` Jens Axboe [this message]
2019-09-04 20:43 ` Jens Axboe
2019-09-05 15:00 ` Jens Axboe
2019-09-05 15:11 ` Jeff Moyer
2019-09-05 15:14 ` Jens Axboe
2019-09-05 16:10 ` Jeff Moyer
2019-09-05 16:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f8ba952-418c-d63d-6b3e-021cae4cfecc@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=jmoyer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox