From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: fio@vger.kernel.org
Subject: Re: io_uring engine -- sqthread_poll option can't work as implemented
Date: Thu, 5 Sep 2019 09:00:48 -0600 [thread overview]
Message-ID: <7a3c83bd-4bbe-72ca-b690-5b247e8b9fd0@kernel.dk> (raw)
In-Reply-To: <0edfb602-184c-f33b-485e-221be543b069@kernel.dk>
On 9/4/19 2:43 PM, Jens Axboe wrote:
> On 9/4/19 2:10 PM, Jens Axboe wrote:
>> On 9/3/19 5:49 AM, Jeff Moyer wrote:
>>> Jens Axboe <axboe@kernel.dk> writes:
>>>
>>>> On 8/29/19 10:38 AM, Jeff Moyer wrote:
>>>>> Hi,
>>>>>
>>>>> sqthread_poll requires registered files in order to work. That's not
>>>>> implemented in fio, and I don't see how one would go about it (but I'm
>>>>> not all that familiar with fio's architecture). We basically need all
>>>>> files to be opened before we can register them. It looks to me as
>>>>> though the files are opened on demand, after the io engine is
>>>>> initialized.
>>>>>
>>>>> Any suggestions?
>>>>
>>>> Leftover from previously, when that requirement wasn't there... Using
>>>> it from fio would require a little bit of footwork, but it's not
>>>> impossible.
>>>
>>> OK, if you can point me in the right direction, I'll take a stab at it.
>>
>> I think if we impose the restriction that the total number of files used
>> must fit in a registered file set, it isn't too hard. Just have the
>> engine open the files when it starts, and provide a new ->open_file()
>> (and ->close_file()) in the engine ops.
>>
>> I'll take a stab at it.
>
> Here's a quick 10 min hack to get this going, if you want to run with
> this, that'd be great. What is still needed:
>
> 1) Test it... I just ran a basic test to verify it does what I think it
> should, that's all.
> 2) Keep the standalone option, but make sqthread_poll imply this option
> as well.
> 3) Probably add a check whether o->nr_files fits in a set. Or maybe it's
> fine not to, the system call will complain anyway.
> 4) Ensure it works with things like loops= that restart things.
> 5) Probably various things I didn't think of yet.
I ran a few more tests and it seems fine, so I fixed up a bit of
error handling and committed it.
--
Jens Axboe
next prev parent reply other threads:[~2019-09-05 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 16:38 io_uring engine -- sqthread_poll option can't work as implemented Jeff Moyer
2019-08-31 3:18 ` Jens Axboe
2019-09-03 11:49 ` Jeff Moyer
2019-09-04 20:10 ` Jens Axboe
2019-09-04 20:43 ` Jens Axboe
2019-09-05 15:00 ` Jens Axboe [this message]
2019-09-05 15:11 ` Jeff Moyer
2019-09-05 15:14 ` Jens Axboe
2019-09-05 16:10 ` Jeff Moyer
2019-09-05 16:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a3c83bd-4bbe-72ca-b690-5b247e8b9fd0@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=jmoyer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox