From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <damien.lemoal@wdc.com>,
fio@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Cc: Matias Bjorling <matias.bjorling@wdc.com>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Dmitry Fomichev <dmitry.fomichev@wdc.com>
Subject: Re: [PATCH 1/8] zbd: Fix partition block device handling
Date: Wed, 20 Feb 2019 08:00:20 -0800 [thread overview]
Message-ID: <1550678420.93548.19.camel@acm.org> (raw)
In-Reply-To: <20190220071725.8487-2-damien.lemoal@wdc.com>
On Wed, 2019-02-20 at 16:17 +0900, Damien Le Moal wrote:
> From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
>
> For fio to correctly handle the zonemode=zbd mode with partitions of
> zoned block devices, the partition block device file must be identified
> as a zoned disk. However, partition block device files do not have
> a zoned sysfs file. This patch allows a correct identification of the
> device file zone model by accessing the sysfs "zoned" file of the
> holder disk for partition devices.
>
> Change get_zbd_model() function to resolve the symbolic link to the
> sysfs path to obtain the canonical sysfs path. The canonical sysfs
> path of a partition device includes both of the holder device name and
> the partition device name. If the given device is a partition device,
> cut the partition device name in the canonical sysfs path to access
> the "zoned" file in the holder device sysfs path.
Please explain what makes you think that it makes sense to create
partitions on a zoned block device. An application that wants to write
to a partition of a zoned block device needs access to the whole disk
anyway to get permission to submit the BLKREPORTZONE and BLKRESETZONE
ioctls. So why would anyone create partitions on a zoned block device?
Thanks,
Bart.
next prev parent reply other threads:[~2019-02-20 16:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 7:17 [PATCH 0/8] ZBD support fixes Damien Le Moal
2019-02-20 7:17 ` [PATCH 1/8] zbd: Fix partition block device handling Damien Le Moal
2019-02-20 16:00 ` Bart Van Assche [this message]
2019-02-21 1:47 ` Damien Le Moal
2019-02-20 7:17 ` [PATCH 2/8] sg: Avoid READ CAPACITY failures Damien Le Moal
2019-02-20 16:03 ` Bart Van Assche
2019-02-20 7:17 ` [PATCH 3/8] t/zbd: Fix handling of partition devices Damien Le Moal
2019-02-20 7:17 ` [PATCH 4/8] t/zbd: Fix test 2 and 3 result handling Damien Le Moal
2019-02-20 16:06 ` Bart Van Assche
2019-02-20 7:17 ` [PATCH 5/8] t/zbd: Default to using blkzone tool Damien Le Moal
2019-02-20 7:17 ` [PATCH 6/8] zbd: Fix zone locking for async I/O engines Damien Le Moal
2019-02-20 7:17 ` [PATCH 7/8] zbd: Avoid async I/O multi-job workload deadlock Damien Le Moal
2019-02-20 7:17 ` [PATCH 8/8] t/zbd: Add multi-job libaio test Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550678420.93548.19.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=dmitry.fomichev@wdc.com \
--cc=fio@vger.kernel.org \
--cc=matias.bjorling@wdc.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox