Re: [PATCH 4/8] t/zbd: Fix test 2 and 3 result handling

[Bart Van Assche <bvanassche@acm.org>]

On Wed, 2019-02-20 at 16:17 +0900, Damien Le Moal wrote:
> Removal of the message "No I/O performed" when fio does not execute any
> I/O broke zbd tests 2 and 3 as this message is looked after to test for
> success. Fix this by looking for a "Run status" line starting with
> "WRITE:" for test 2 and "READ:" for test 3. The run status lines are not
> printed when no I/O is performed. Testing for the absence of these
> strings thus allows to easily test if I/Os where executed or not.
> 
> Fixes: ff3aa922570c ("Kill "No I/O performed by ..." message")
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
>  t/zbd/test-zbd-support | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/t/zbd/test-zbd-support b/t/zbd/test-zbd-support
> index d316d880..c6391169 100755
> --- a/t/zbd/test-zbd-support
> +++ b/t/zbd/test-zbd-support
> @@ -141,9 +141,9 @@ test2() {
>      if [ -z "$is_zbd" ]; then
>  	opts+=("--zonesize=${zone_size}")
>      fi
> -    run_fio "${opts[@]}" 2>&1 |
> -	tee -a "${logfile}.${test_number}" |
> -	grep -q 'No I/O performed'
> +    run_fio "${opts[@]}" >> "${logfile}.${test_number}" 2>&1 || return $?
> +    grep -q 'WRITE:' "${logfile}.${test_number}"
> +    [ $? != 0 ]
>  }

Can the last two lines be changed into the following single line?

! grep -q 'WRITE:' "${logfile}.${test_number}"

Thanks,

Bart.